[HOLD for payment 2023-11-20] [$125] Dot separator in the report preview component appears bottom aligned

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.3.83-10
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: (internal)

Action Performed:

1. Global create > request money
2. Create a request
3. As the payer, click Pay elsewhere to settle up
4. Observe the "Cash - Paid elsehwere" dot separator position in the report preview component is bottom-aligned

Expected Result:

The dot separator should be center-aligned:

Actual Result:

It looks bottom-aligned:

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Yes, visual design bug.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01765a32b3ae401177
• Upwork Job ID: 1712776284859080704
• Last Price Increase: 2023-10-13
• Automatic offers:
• tienifr | Contributor | 27177642

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01765a32b3ae401177

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[trjExpensify]

@shawnborton @dannymcclain @dubielzyk-expensify for vis and confirmation!

[trjExpensify]

Also, when testing this I noticed that Distance has Done after the dot separator, but it should use the appropriate payment method like all other requests. E.g Paid or Paid elsewhere. We may as well fix that here as well. CC: @neil-marcellini @JmillsExpensify not sure when or why that happened.

[melvin-bot]

Upwork job price has been updated to $125

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dot separator in the report preview component appears bottom aligned

What is the root cause of that problem?

We're adding marginBottom: 4px for 2 texts but not icon

App/src/components/ReportActionItem/MoneyRequestPreview.js

Lines 267 to 276 in c9ccae3

	<Text style={[styles.textLabelSupporting, styles.mb1, styles.lh20]}>{getPreviewHeaderText()}</Text>
	{isSettled && (
	<>
	<Icon
	src={Expensicons.DotIndicator}
	width={4}
	height={4}
	additionalStyles={[styles.mr1, styles.ml1]}
	/>
	<Text style={[styles.textLabelSupporting, styles.mb1, styles.lh20]}>{getSettledMessage()}</Text>

What changes do you think we should make in order to solve the problem?

Add styles.mb1 for Icon

Or we can remove styles.mb1 in both text component and add styles.mb1 to the wrapped view

Result

[rushatgabhane]

@tienifr proposal lgtm!

please raise a PR
cc @mountiny

[rushatgabhane]

🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @techievivek, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mountiny]

@tienifr nice! Can you also include the change for the Done? Asking @trjExpensify what should go there instead

[melvin-bot]

📣 @rushatgabhane Please request via NewDot manual requests for the Contributor role ($125)

[melvin-bot]

📣 @rushatgabhane Please request via NewDot manual requests for the Reviewer role ($125)

[tienifr]

The PR fix: #30231 is up

[melvin-bot]

This issue has not been updated in over 15 days. @trjExpensify, @rushatgabhane, @mountiny, @tienifr eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mountiny]

I believe this is ready for payment now

[trjExpensify]

We're still awaiting the checklist. Also, can we confirm the number of regressions here?

It seems like one so that takes us to $62.5 as the bounty due to @rushatgabhane & @tienifr, right?

[trjExpensify]

Bump!

[trjExpensify]

Bump, @rushatgabhane.

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: feat(26270): Add Skeleton UI for Money Requests #26613

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/26613/files#r1408803786

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required because small bug.

4. Determine if we should create a regression test for this bug. No

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - No

[rushatgabhane]

@trjExpensify sorry for the delay 🙇 We can close this issue now

[trjExpensify]

Do we need to issue payouts as per this? #29543 (comment)

[trjExpensify]

Chatted to Rushat, yes payments are $62.50.

• @rushatgabhane you can go ahead and request.
• @tienifr I've paid you.

[JmillsExpensify]

$62.50 payment approved for @rushatgabhane based on the comment above.