Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD 19330]Mobile app - Task Title doesn't overflow #22030

Closed
4 of 6 tasks
kavimuru opened this issue Jul 2, 2023 · 13 comments
Closed
4 of 6 tasks

[HOLD 19330]Mobile app - Task Title doesn't overflow #22030

kavimuru opened this issue Jul 2, 2023 · 13 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kavimuru
Copy link

kavimuru commented Jul 2, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

1-Press the plus sign,
2-Open Assign task,
3-Give it a long title,
4-Click in button Next,
5-Add an assignee
6-choose share somewhere,
7-Click in button Confirm task,
8-Click Mark as done

Expected Result:

Observe that only half of the message is visible

Actual Result:

message view overflows

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

video_2023-07-02_00-07-53.mp4
Screen_Recording_20230630_022256_New.Expensify.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Mauri-salazar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688103445957509

View all open jobs on GitHub

@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 2, 2023

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 2, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@honnamkuan
Copy link
Contributor

honnamkuan commented Jul 3, 2023

Note: Issue can be reproducible only in certain platforms, reproducible in Android Native app

Proposal

Please re-state the problem that we are trying to solve in this issue.

For task with long title, after marking the task as complete, the "completed task" message overflow to the edge of the screen.

What is the root cause of that problem?

There is not flex or width styling in

<Text style={[styles.chatItemMessage]}>{` ${taskReportName}`}</Text>

which causes the text to overflow

What changes do you think we should make in order to solve the problem?

Update the below to have style={[styles.chatItemMessage, styles.flex1]

<Text style={[styles.chatItemMessage]}>{` ${taskReportName}`}</Text>

Results:
image

@Christinadobrzyn Christinadobrzyn changed the title Allocation task message overflows Task Title doesn't overflow Jul 3, 2023
@Christinadobrzyn Christinadobrzyn changed the title Task Title doesn't overflow Mobile app - Task Title doesn't overflow Jul 3, 2023
@Christinadobrzyn
Copy link
Contributor

I can reproduce it - I think this might be related to #21347 (comment) asking

@dhairyasenjaliya
Copy link
Contributor

Hy @Christinadobrzyn we are not fixing that but we should hold or close this issue since this is likely to redesign here #19330

@Christinadobrzyn
Copy link
Contributor

Alright, we'll hold for #19330

@Christinadobrzyn Christinadobrzyn changed the title Mobile app - Task Title doesn't overflow [HOLD 19330]Mobile app - Task Title doesn't overflow Jul 5, 2023
@Christinadobrzyn Christinadobrzyn added Weekly KSv2 and removed Daily KSv2 labels Jul 5, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 13, 2023
@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Jul 14, 2023

I'm going to be ooo until July 31st so going to unassign and assign a new teammate.

@dylanexpensify At this time, we're on hold waiting to see if #19330 will fix this. I'll take this if it's still open when I'm back.

@melvin-bot melvin-bot bot removed the Overdue label Jul 14, 2023
@Christinadobrzyn Christinadobrzyn removed the Bug Something is broken. Auto assigns a BugZero manager. label Jul 14, 2023
@Christinadobrzyn Christinadobrzyn removed their assignment Jul 14, 2023
@Christinadobrzyn Christinadobrzyn added the Bug Something is broken. Auto assigns a BugZero manager. label Jul 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 14, 2023
@melvin-bot

This comment was marked as outdated.

@Christinadobrzyn Christinadobrzyn self-assigned this Jul 14, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 17, 2023
@dylanexpensify
Copy link
Contributor

Reviewing today!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 17, 2023
@dylanexpensify
Copy link
Contributor

@dhairyasenjaliya still on hold yeah?

@melvin-bot melvin-bot bot removed the Overdue label Jul 20, 2023
@dhairyasenjaliya
Copy link
Contributor

@dylanexpensify this can be closed since now its redesigned

@dylanexpensify
Copy link
Contributor

perfect, ty!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

5 participants