Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-07-20] Task Detailed View Redesign #19330

Closed
thienlnam opened this issue May 19, 2023 · 53 comments
Closed

[HOLD for payment 2023-07-20] Task Detailed View Redesign #19330

thienlnam opened this issue May 19, 2023 · 53 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@thienlnam
Copy link
Contributor

thienlnam commented May 19, 2023

image
image
image
image

Update the task detailed view to look like the above mockups
This issue is mostly focusing on the detailed view within the task. There will be another issue for the LHN / header title view as well as the deleted view, so no need to worry about those here

  • Move the 'Mark as done' button to the header
  • The task details float above the comments in the report and can be scrolled out of screen if there are enough comments
  • The task title now contains a checkbox that can be used
  • When there is no assignee or description, it should middle align the input

image
image

https://expensify.slack.com/archives/C04QEB4MJEQ/p1684396364608389

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0184754c976c0dca40
  • Upwork Job ID: 1666918061946351616
  • Last Price Increase: 2023-06-15
@thienlnam thienlnam added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 19, 2023

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@thienlnam thienlnam added Weekly KSv2 and removed Daily KSv2 labels May 19, 2023
@JmillsExpensify
Copy link

Oh cool, glad I randomly got assigned on this issue. I think those are good questions. Just a quick heads up that I'm out of office the remainder of this week.

@JmillsExpensify JmillsExpensify added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels May 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 22, 2023

@melvin-bot melvin-bot bot added the Overdue label May 30, 2023
@Expensify Expensify deleted a comment from melvin-bot bot May 30, 2023
@twisterdotcom
Copy link
Contributor

I'm not super sure what we should do with this. Do we both need to pre-design how to handle all these questions?

@melvin-bot melvin-bot bot removed the Overdue label May 30, 2023
@thienlnam
Copy link
Contributor Author

Yup, looks like @JmillsExpensify and @shawnborton are leading up this new header view that works for tasks/money requests/threads

https://expensify.slack.com/archives/C04QEB4MJEQ/p1684777292283899

@thienlnam
Copy link
Contributor Author

Reassigning since this is holding on that pre-design conversation

@shawnborton
Copy link
Contributor

Addressing this in the threads.

@thienlnam
Copy link
Contributor Author

Planning on making this external so we can get some movement on this issue - I've included the relevant mock-ups in the description - are we pretty set with this or are we still finalizing some elements? cc @JmillsExpensify @shawnborton

@thienlnam thienlnam self-assigned this Jun 7, 2023
@JmillsExpensify
Copy link

Let's make sure that we don't include the icons! Those were removed

@JmillsExpensify
Copy link

JmillsExpensify commented Jun 8, 2023

Also, I still have some reservations here. Can we take this back to Slack?

@thienlnam
Copy link
Contributor Author

This is ready now, updated the description with the latest convo from slack!

@thienlnam thienlnam changed the title [HOLD]Task design feedback Task Detailed View Redesign Jun 8, 2023
@thienlnam thienlnam added the External Added to denote the issue can be worked on by a contributor label Jun 8, 2023
@melvin-bot melvin-bot bot changed the title Task Detailed View Redesign [$1000] Task Detailed View Redesign Jun 8, 2023
@melvin-bot melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Jul 13, 2023
@melvin-bot melvin-bot bot changed the title Task Detailed View Redesign [HOLD for payment 2023-07-20] Task Detailed View Redesign Jul 13, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 13, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jul 13, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.39-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-07-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@Christinadobrzyn
Copy link
Contributor

Hired @fedirjh in Upwork

Internal job - https://www.upwork.com/ab/applicants/1666918061946351616/job-details
External job - https://www.upwork.com/jobs/~0184754c976c0dca40

@fedirjh or @jasperhuangg Should a regression test apply to this?

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Jul 14, 2023

I'm going to be ooo until July 31st so going to unassign and assign a new teammate.

@JmillsExpensify At this time, we're reviewing PR and prepping for payment based on #19330 (comment)

I'll take this back if it's still open when I'm back

@Christinadobrzyn Christinadobrzyn added the Bug Something is broken. Auto assigns a BugZero manager. label Jul 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 14, 2023
@melvin-bot

This comment was marked as outdated.

@Christinadobrzyn Christinadobrzyn self-assigned this Jul 14, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 17, 2023
@jasperhuangg
Copy link
Contributor

Hired @fedirjh in Upwork

Internal job - https://www.upwork.com/ab/applicants/1666918061946351616/job-details External job - https://www.upwork.com/jobs/~0184754c976c0dca40

@fedirjh or @jasperhuangg Should a regression test apply to this?

No need for a regression test, the existing regression tests should cover this flow

@melvin-bot melvin-bot bot removed the Overdue label Jul 17, 2023
@jasperhuangg
Copy link
Contributor

This is still on HOLD for payment not overdue

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Daily KSv2 labels Jul 19, 2023
@jasperhuangg
Copy link
Contributor

@fedirjh were you paid out?

@melvin-bot melvin-bot bot removed the Overdue label Jul 21, 2023
@fedirjh
Copy link
Contributor

fedirjh commented Jul 21, 2023

were you paid out?

@jasperhuangg I was hired but not yet paid , I think @Christinadobrzyn is ooo till July 31st .

@jasperhuangg
Copy link
Contributor

@JmillsExpensify Can you help make sure @fedirjh gets paid out? It looks like @Christinadobrzyn has already hired them on Upwork: #19330 (comment)

@melvin-bot melvin-bot bot added the Overdue label Jul 24, 2023
@jasperhuangg
Copy link
Contributor

@JmillsExpensify friendly bump! Can we get @fedirjh paid out for reviewing the PR?

@melvin-bot melvin-bot bot removed the Overdue label Jul 24, 2023
@JmillsExpensify
Copy link

Jumping in now! Thanks

@JmillsExpensify
Copy link

Alright, @fedirjh is all paid out. I didn't see any automation related to a an urgency bonus, or any other mention of it, so I've paid the $1k standard amount.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

9 participants