-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-07-20] Task Detailed View Redesign #19330
Comments
Triggered auto assignment to @JmillsExpensify ( |
Oh cool, glad I randomly got assigned on this issue. I think those are good questions. Just a quick heads up that I'm out of office the remainder of this week. |
Triggered auto assignment to @twisterdotcom ( |
I'm not super sure what we should do with this. Do we both need to pre-design how to handle all these questions? |
Yup, looks like @JmillsExpensify and @shawnborton are leading up this new header view that works for tasks/money requests/threads https://expensify.slack.com/archives/C04QEB4MJEQ/p1684777292283899 |
Reassigning since this is holding on that pre-design conversation |
Addressing this in the threads. |
Planning on making this external so we can get some movement on this issue - I've included the relevant mock-ups in the description - are we pretty set with this or are we still finalizing some elements? cc @JmillsExpensify @shawnborton |
Let's make sure that we don't include the icons! Those were removed |
Also, I still have some reservations here. Can we take this back to Slack? |
This is ready now, updated the description with the latest convo from slack! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.39-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-07-20. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
Hired @fedirjh in Upwork Internal job - https://www.upwork.com/ab/applicants/1666918061946351616/job-details @fedirjh or @jasperhuangg Should a regression test apply to this? |
I'm going to be ooo until July 31st so going to unassign and assign a new teammate. @JmillsExpensify At this time, we're reviewing PR and prepping for payment based on #19330 (comment) I'll take this back if it's still open when I'm back |
Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new. |
This comment was marked as outdated.
This comment was marked as outdated.
No need for a regression test, the existing regression tests should cover this flow |
This is still on HOLD for payment not overdue |
@fedirjh were you paid out? |
@jasperhuangg I was hired but not yet paid , I think @Christinadobrzyn is ooo till July 31st . |
@JmillsExpensify Can you help make sure @fedirjh gets paid out? It looks like @Christinadobrzyn has already hired them on Upwork: #19330 (comment) |
@JmillsExpensify friendly bump! Can we get @fedirjh paid out for reviewing the PR? |
Jumping in now! Thanks |
Alright, @fedirjh is all paid out. I didn't see any automation related to a an urgency bonus, or any other mention of it, so I've paid the $1k standard amount. |
Update the task detailed view to look like the above mockups
This issue is mostly focusing on the detailed view within the task. There will be another issue for the LHN / header title view as well as the deleted view, so no need to worry about those here
https://expensify.slack.com/archives/C04QEB4MJEQ/p1684396364608389
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: