[HOLD for payment 2023-07-17] [$1000] mWeb - the confirm task screen is not scrollable, when a task description has multiple line

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click on + icon and select Assign task option
2. Enter title and description(with multiple line ~17line)
3. Click on Next button
4. Add any Assignee and share somewhere

Example description text for your copy-pasta pleasure

Lupin Gardens is an established horticultural company creating beautiful gardens in Birmingham and selected surrounding areas. Our expert team provide all aspects of the garden design, installation, creative planting and aftercare. Plants and soft landscaping are at the heart of everything we do. Whatever you envisage for your garden – a complete redesign, including hard landscaping and planting, or just regular, skilful care – Lupin has a dedicated group of professionals to advise and assist.

Established in 2001, Lupin has
been redesigning,
renovating, renewing and
maintaining gardens in
Birmingham for almost twenty years. Steadily expanding its core team to provide
knowledgable, professional
expertise of the highest quality, we pride ourselves on taking a realistic and
sustainable approach to gardening.
Lupin utilises the skills of
horticulturalists, designers,
landscapers and gardeners to provide solutions to any garden dilemma – large or small.

Expected Result:

The confirm task screen should be scrollable even when there's a very long description (ie: to scroll down to the Assignee and Share somewhere settings, and Confirm task button)

Actual Result:

The confirm task screen is not scrollable when there's a very long description, and as a result you can't scroll down to the Assignee and Share somewhere settings, and Confirm task button (so you can't save the task)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.31.1

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

IMG_0422.mov

Screen_Recording_20230622_161608_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686906456520119

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014291752cbe61aa50
• Upwork Job ID: 1672157676998672384
• Last Price Increase: 2023-06-23

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dhairyasenjaliya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• mWeb - confirm task screen not scrollable when description has multiple line

What is the root cause of that problem?

• The root cause is we are not using scroll view on NewTaskPage.js that makes contact on static view or even we are not limiting the number of lines to display text description that causes overflow and makes content static

What changes do you think we should make in order to solve the problem?

Solution 1

• On NewTaskPage.js we should wrap that page on <Scrollview> so that it can easily be scrollable

Result With added Scrollview

scroll.mov

Solution 2

• Also we can define a fixed line for the description currently it's not defined we can limit to display on that page

• We need to define new props to <MenuItem> that allows to add numberOfLine of title and after that, we just pass titleNumberOfLine={5} that we are using max number of line on the description text input

Result With added Fixed number of line

< /details>

[conorpendergrast]

Reproduced on iOS Safari, and added some sample text to the OP (behind a <details>) for testing

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014291752cbe61aa50

[melvin-bot]

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[ShogunFire]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The confirm task screen is not scrollable so if the description of the task is very long we can't see part of the screen

What is the root cause of that problem?

As @dhairyasenjaliya said here , we don't currently have a scrollview for that screen

What changes do you think we should make in order to solve the problem?

I believe if the description is very long it can be confusing for the user if we have a scrollview for the whole screen because he will not understand what that screen is for, I believe it would be a better UX if we only put the scrollView around the description field, that way the user will always see the button "Confirm task" at the bottom. Also that way the user doesn't have to scroll a long time to click that button.

What alternative solutions did you explore? (Optional)

We could also put the whole screen scrollable but scroll until the bottom automatically which also resolve the problems that I mentionned

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[allroundexperts]

Thanks for your proposal @ShogunFire. I agree that for better UX, we should keep the Confirm button at a fixed position. However, I feel like your proposal is just adding onto what @dhairyasenjaliya suggested earlier in his proposal.

@dhairyasenjaliya let's go with your solution 1 as described here. For consistency, its better to keep the submit button static like we're doing elsewhere. Eg:
https://github.com/Expensify/App/assets/30054992/858cc4b9-8a3e-4e89-a5ed-dcc0852a2f4c

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @cead22, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[ShogunFire]

@allroundexperts The solution was not very hard to find so I thought adding a little bit to the initial proposal would do it but I respect your decision.

[dhairyasenjaliya]

alright let's do solution - 1, generating PR soon once I get assigned thank you @allroundexperts

@ShogunFire I was well aware of that situation but that button thing I need to confirm from the team since we have both the approach on the app e.g: We are adding a static button on invite flow but if you try to add a manual account you will find that similar button is at very bottom that is dynamically added to the bottom according to the content of screen either of both decision I just need to adjust <Scrollview> based on the team confirmation that doesn't change my proposal in any terms :)

[melvin-bot]

📣 @dhairyasenjaliya You have been assigned to this job by @cead22!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dhairyasenjaliya]

@allroundexperts pr ready for review

[Christinadobrzyn]

Hi @allroundexperts @dhairyasenjaliya Can you confirm if this is the same issue or will be fixed with this? #22030

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @dhairyasenjaliya got assigned: 2023-06-26 19:25:43 Z
• when the PR got merged: 2023-07-06 22:30:13 UTC
• days elapsed: 8

On to the next one 🚀

[melvin-bot]

@cead22, @conorpendergrast, @allroundexperts, @dhairyasenjaliya Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Task description scroll #21553

If no regressions arise, payment will be issued on 2023-07-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - @gadhiyamanan
• Contributor that fixed the issue - @dhairyasenjaliya
• Contributor+ that helped on the issue and/or PR - @allroundexperts - Via New Expensify

https://www.upwork.com/ab/applicants/1672157676998672384/hired

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[conorpendergrast]

Sent contracts for everyone, via Upwork

[allroundexperts]

I'll be getting paid via the App @conorpendergrast. Can you please withdraw the offer from Upwork?

[dhairyasenjaliya]

hey @conorpendergrast just want to confirm if this is eligible for an urgency bonus or not, since I have created PR and reviewed it by @allroundexperts within 3 days but after that, we just changed the scope of the issue and that was also done on time after that we were just waiting for merged by engineer

[conorpendergrast]

@dhairyasenjaliya I'll discuss that request internally, then come back here

Paid @gadhiyamanan, in the meantime

[gadhiyamanan]

@conorpendergrast can you please close the upwork contact
Thanks!

[conorpendergrast]

@gadhiyamanan Done, sorry I missed that and thanks for the reminder.

@dhairyasenjaliya @allroundexperts After discussion, @cead22 and I agree with your request and will make an exception, to add the 50% urgency bonus here.

@dhairyasenjaliya I've paid you, plus the 50% urgency bonus, via Upwork.

@allroundexperts Please include the 50% urgency bonus in your New Expensify request!

[conorpendergrast]

Finally steps are for @allroundexperts to complete the checklist, and then to get paid.

[allroundexperts]

@conorpendergrast I think the checklist is not needed here. We did not consider how a very long description would show up on the confirm task screen when creating the tasks feature. In fact, the expected behaviour was not even clear when this issue was created and we decided it here after some discussion.

[conorpendergrast]

That works, closing this out! (I clarified the process is to close out even before the C+, NewDot payment)

[anmurali]

Approved $1500 to @allroundexperts for $1500 based on #21347 (comment)