[HOLD for payment 2023-06-01] [$1000] URL of Share code treated as email instead of URL

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to settings > Share code
2. click on share to copy the share code
3. Go any chat
4. paste the link

Expected Result:

should be treated as link

Actual Result:

does not treat as URL and on click it opens mail

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.14-14
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-16.at.2.44.04.PM.mov

Recording.631.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684228471954519 #19039 (comment)

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017871c028abb202e9
• Upwork Job ID: 1658796901345894400
• Last Price Increase: 2023-05-17

[melvin-bot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ahmedGaber93]

I think it duplicated #16762

[hungvu193]

Proposal

We should fix this issue because it related to another issue here: #19062

Please re-state the problem that we are trying to solve in this issue.

URL of Share code treated as email instead of URL

What is the root cause of that problem?

We didn't encode the param for the share url in here which causes the issue.

App/src/pages/ShareCodePage.js

Line 41 in 811c0f3

const url = isReport ? `${CONST.NEW_EXPENSIFY_URL}r/${this.props.report.reportID}` : `${CONST.NEW_EXPENSIFY_URL}details?login=${this.props.session.email}`;

What changes do you think we should make in order to solve the problem?

We should encode the email params of the share url:

const url = isReport ? `${CONST.NEW_EXPENSIFY_URL}r/${this.props.report.reportID}` : `${CONST.NEW_EXPENSIFY_URL}details?login=${encodeURIComponent(this.props.session.email)}`;

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017871c028abb202e9

[melvin-bot]

Current assignee @tjferriss is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Triggered auto assignment to @robertjchen (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[tjferriss]

Easily reproduced.

[melvin-bot]

📣 @AlexanderDmitriev! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[robertjchen]

Proposal sounds good to me

[hungvu193]

Thanks @robertjchen , what's the next step from here?

[robertjchen]

Normally we'd get a signoff from C+ https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md but I think this is simple enough to proceed 🤔 (Though, definitely feel free to chime in @eVoloshchak if you think there's a better approach).

@tjferriss Could you please hire @hungvu193 on upwork to proceed with the implementation of the solution? Thanks!

[melvin-bot]

📣 @hungvu193 You have been assigned to this job by @michaelhaxhiu!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Nathan-Mulugeta]

I was on this issue @michaelhaxhiu and I noticed that the PR for this issue also fixed #19039. So I thought the RCA might be the same for both issues. That’s how I got here.

[therealsujitk]

@michaelhaxhiu both issues are the exact same, the url variable is passed to the QR code and the copy button as a prop. This issue (#19076) references the copy button while the other (#19039) references the QR code. Fixing the url variable fixed both issues.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.17-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: URL of Share code treated as email instead of URL #19249

If no regressions arise, payment will be issued on 2023-06-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter @Nathan-Mulugeta
• Contributor that fixed the issue @hungvu193
• Contributor+ that helped on the issue and/or PR @eVoloshchak

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/288769

[gadhiyamanan]

I'm brewing. I can't tell if these bug reports are exactly 1:1 or not 🤔 there's a possibility we pay you both for the bug reports but it'd be helpful to get your input on how they are the same or different cc @Nathan-Mulugeta and @gadhiyamanan

I think all 4 issues #19076 #19062 #19344 #19039 have the same RCA and we can combine them. only one issue eligible for reporting bonus which is #19062 because it was the first which is reported on Slack. what are your thoughts?

cc: @michaelhaxhiu @sonialiap @bfitzexpensify

[tjferriss]

An offer has been sent to @eVoloshchak and @Nathan-Mulugeta for the reporting bonus. @hungvu193 I couldn't find you in Upworks. Can you please apply for the job? https://www.upwork.com/jobs/~017871c028abb202e9

@gadhiyamanan I agree with your conclusion on paying the reporting bonus here for all issues.

[hungvu193]

An offer has been sent to @eVoloshchak and @Nathan-Mulugeta for the reporting bonus. @hungvu193 I couldn't find you in Upworks. Can you please apply for the job? https://www.upwork.com/jobs/~017871c028abb202e9

@gadhiyamanan I agree with your conclusion on paying the reporting bonus here for all issues.

Thanks @tjferriss , I've just applied

[Nathan-Mulugeta]

Accepted offer.

[michaelhaxhiu]

Agree with ya @gadhiyamanan + @tjferriss on that payment gameplan 👍

[gadhiyamanan]

@tjferriss @michaelhaxhiu In that case , only @dhanashree-sawant is eligible for reporting bonus as she was the first to report it in slack for this issue

[robertjchen]

Thanks for sorting this out- are we all set to close out this issue here? 🙏

[hungvu193]

I didn't receive the payment yet, so I think after everyone is paid we can close this one.

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: Feat: Share QR Code #18636

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/18636/files#r1212280330

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1685566039117729

• Determine if we should create a regression test for this bug.
  Is it easy to test for this bug? Yes
  Is the bug related to an important user flow? Yes
  Is it an impactful bug? Yes

[eVoloshchak]

Regression Test Proposal

1. Go to settings > Share code

2. Click on Share to copy the share code

3. Go to any chat

4. Paste the link

5. Verify the link is displayed correctly, all of the message is formatted as link

6. Sign in with your phone number

7. Go to Settings > Share code

8. Click Copy URL to clipboard

9. Next, sign in with another account

10. Paste and open the copied URL

11. Click on Message ...

12. Verify there is no 'Report no longer exists' error

Do we agree 👍 or 👎

[tjferriss]

All payments have been made in Upworks and the regression test has been submitted to Applause.

[dhanashree-sawant]

Hi @tjferriss, I have recieved the offer but It is still pending to be approved, can you have a look once you are available?

[tjferriss]

Done.