Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] @expensify.sms is displayed next to the phone number in the user profile details #19346

Closed
1 of 6 tasks
kavimuru opened this issue May 20, 2023 · 18 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kavimuru
Copy link

kavimuru commented May 20, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Sign in with your phone number
  2. Go to Settings > Share code
  3. Click Copy URL to clipboard
  4. Open a new tab
  5. Paste and go to the copied URL

Expected Result:

@expensify.sms is not displayed next to the phone number

Actual Result:

'@expensify.sms is displayed next to the phone number

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.16-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-18.at.12.58.43.AM.mov
Untitled

Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684353586002219

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0110528670e4f9464d
  • Upwork Job ID: 1661143360429584384
  • Last Price Increase: 2023-05-23
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 20, 2023

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented May 20, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@Prince-Mendiratta
Copy link
Contributor

Should be solved by #19076, I believe.

@jliexpensify
Copy link
Contributor

@robertjchen - since you're assigned to #19076, just confirming that your issue will resolve this one? If so, could we close this one? Thanks!

@robertjchen
Copy link
Contributor

Hm, this is a bit different- we should be excising the @expensify.sms part and we discussed it a bit here: https://expensify.slack.com/archives/C049HHMV9SM/p1684739607316259

I'll take a look at this one 👍

@jliexpensify
Copy link
Contributor

Thanks @robertjchen - just assigned you to this, LMK if you want it moved to External.

@robertjchen
Copy link
Contributor

Ah, on revisiting this, I realize that this is different than the other issue I mentioned and should be resolved by #19076

@adeel0202
Copy link
Contributor

adeel0202 commented May 23, 2023

@robertjchen, shouldn't this be added to this list and shouldn't I be compensated for reporting once this gets fixed by that PR? 😅
cc @jliexpensify

@jliexpensify
Copy link
Contributor

Yep, @adeel0202 you get the $250 - will send you an invite on Upworks.

@jliexpensify jliexpensify added the External Added to denote the issue can be worked on by a contributor label May 23, 2023
@melvin-bot melvin-bot bot changed the title @expensify.sms is displayed next to the phone number in the user profile details [$1000] @expensify.sms is displayed next to the phone number in the user profile details May 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 23, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0110528670e4f9464d

@melvin-bot
Copy link

melvin-bot bot commented May 23, 2023

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented May 23, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 23, 2023

Current assignee @robertjchen is eligible for the External assigner, not assigning anyone new.

@jliexpensify
Copy link
Contributor

Ok so Upworks won't let me reuse any Job posts, so have to drop the External label - sorry! Will unassign the C+.

@adeel0202
Copy link
Contributor

Thanks @jliexpensify. I have applied.

@jliexpensify
Copy link
Contributor

Cool, tag me when you've accepted and I'll pay ASAP.

@adeel0202
Copy link
Contributor

Accepted, @jliexpensify

@jliexpensify
Copy link
Contributor

jliexpensify commented May 24, 2023

Paid and Upworks job closed, cheers!

EDIT: I realize I paid early...whoops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

6 participants