Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-02-02 #14771

Closed
30 tasks done
thienlnam opened this issue Feb 2, 2023 · 19 comments
Closed
30 tasks done

Deploy Checklist: New Expensify 2023-02-02 #14771

thienlnam opened this issue Feb 2, 2023 · 19 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@thienlnam
Copy link
Contributor

thienlnam commented Feb 2, 2023

Release Version: 1.2.64-7
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Feb 2, 2023
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Feb 2, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Feb 2, 2023

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.64-3 🚀

@thienlnam
Copy link
Contributor Author

Checked off 14454, needs internal prod QA

@roryabraham
Copy link
Contributor

roryabraham commented Feb 3, 2023

I just noticed for the first time that arrow key navigation on:

  • search page
  • new chat page
  • new group page

seems broken. This functionality was added in #7702 and regression tests for these features were added here

Edit: Confirmed that this is not reproducible on production, so it's a deploy blocker.

@melvin-bot melvin-bot bot unlocked this conversation Feb 3, 2023
@melvin-bot

This comment was marked as resolved.

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Feb 3, 2023
@Expensify Expensify unlocked this conversation Feb 3, 2023
@roryabraham
Copy link
Contributor

Created #14787

@OSBotify
Copy link
Contributor

OSBotify commented Feb 3, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.64-5 🚀

@Beamanator
Copy link
Contributor

Beamanator commented Feb 3, 2023

Just tested #14730 and #13655, results here: #13655 (comment)

The tests looked great mainly, but there were two possible smaller issues (bottom of linked comment) that I think can be resolved without being deploy blockers?

@OSBotify
Copy link
Contributor

OSBotify commented Feb 3, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.64-5 has been deployed to staging 🎉

@Julesssss
Copy link
Contributor

Checked off #14653

@roryabraham
Copy link
Contributor

Checking off #14787

@mvtglobally
Copy link

@thienlnam Regression is completed

#13216 is failing #14818 & #14819 repro in PROD
#14029. We are struggling with testing this PR a bit. So far it seems to be failing #14820 and we are seeing this #7270

@OSBotify
Copy link
Contributor

OSBotify commented Feb 3, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.64-6 🚀

@thienlnam
Copy link
Contributor Author

Checking off #14730 and #13655 from @Beamanator's comments here #13655 (comment)

@OSBotify
Copy link
Contributor

OSBotify commented Feb 3, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.64-6 has been deployed to staging 🎉

@grgia
Copy link
Contributor

grgia commented Feb 3, 2023

Checking off #13501

@OSBotify
Copy link
Contributor

OSBotify commented Feb 3, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.64-7 🚀

@thienlnam
Copy link
Contributor Author

Checking off #14585 with this comment #14585 (comment)

@thienlnam
Copy link
Contributor Author

:shipit:

@OSBotify
Copy link
Contributor

OSBotify commented Feb 4, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.64-7 has been deployed to staging 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

8 participants