-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account Avatar is only updated after a refresh when added/delete cross-platform (NewDot <> OldDot) #14818
Comments
Triggered auto assignment to @trjExpensify ( |
Bug0 Triage Checklist (Main S/O)
|
I'll jump on this on Monday, but @grgia putting it on your radar in the meantime wrt default avatars. |
Triggered auto assignment to @tgolen ( |
I can reproduce this, just like your video, but that differs to the steps/title in the OP. The custom avatar added in NewDot isn't updated in OldDot until after a refresh, and the custom avatar removed in OldDot isn't updated in NewDot until after a refresh. Steps I've updated in the OP are as follows:
Assigning engineering for an opinion on whether this can be external, or if we need to handle this internally as it might be something related to pusher. |
I don't think this is a bug, it should be classified as a new feature. I think this brings up a much wider discussion of potential features... I think before we do this GH, we need to figure out:
There are THOUSANDS of actions you can take in OldDot that would impact NewDot (eg. changing your name, creating policies, submitting reports, yada yada). I do not think that we want to put any effort into keeping the two in sync, since we are going to completely replace OldDot someday. |
Oh, why did I think we already kept the profile data in sync across NewDot and OldDot? 🤔 Cool, if we aren't doing that (I just checked a few fields and you're right), I'm happy to actually just close this out as a new feature request. Switching the label for posterity and closing. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Issue found when executing PR #13216
Action Performed:
Expected Result:
Adding a custom avatar in NewDot doesn't require a refresh in OldDot to show
Removing a custom avatar in OldDot doesn't require a refresh in NewDot to show
Actual Result:
Avatar is only displayed correctly after a refresh
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.2.63.2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Avator.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: