[HOLD for payment 2023-03-20] [$1000] Web - VBA - Clicking secure account opens production OD and after set up redirects to ND login

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #14029

Action Performed:

1. Go to Workspace > Connect bank account and start the process of setting up bank account in VERIFYING state
2. Go till Verifying state and confirm the 2FA prompt as in screenshot
3. Click on "Secure Account" and confirm you're redirected to olddot and 2FA modal is open.
4. Finish the 2FA setup. Upon clicking Finish, confirm you're redirected back to newdot

Expected Result:

"Secure Account" should open 2FA modal in staging and after 2FA setup should redirect to NewDot connect to bank account validation page

Actual Result:

"Secure Account" opens 2FA modal in production OD and after 2FA setup redirects to login page of NewDot

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.64.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5923629_web_14029.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010ee2b2d51ce96d1f
• Upwork Job ID: 1622477194214334464
• Last Price Increase: 2023-03-10

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

cc @MonilBhavsar

[mallenexpensify]

It's 5 on Friday, brain is def not dealing with this now, will get to Monday

[MonilBhavsar]

Thanks for ping!
I think this happens because EXPENSIFY_URL in staging config points to production URL. https://github.com/Expensify/App/blob/main/.env.staging#L3

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010ee2b2d51ce96d1f

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

[MonilBhavsar]

Have asked here for thoughts https://expensify.slack.com/archives/C03TQ48KC/p1675664867491769

[MelvinBot]

@mallenexpensify, @rushatgabhane, @MonilBhavsar Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mallenexpensify]

PR is actively being worked on #14944

[rushatgabhane]

had unassigned because of low bandwidth

[mallenexpensify]

@MonilBhavsar do you want a C+ assigned for PR review? It looks like kidroca, Vit and Alberto are on the PR already so not sure if C+ is needed

[MonilBhavsar]

Yes, we're all good here

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Use app environment to determine olddot URL and update staging env #14944

If no regressions arise, payment will be issued on 2023-03-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt / @MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt / @MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt / @MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mallenexpensify] Determine if we should create a regression test for the bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to the appropriate location to ensure the same bug will not reach production again.
• [@mallenexpensify] Review the proposed regression test steps and location.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MelvinBot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[s77rt]

@MonilBhavsar Since you were involved on this from the start, can you please track the offending PR? Or should I do it?

• The PR that introduced the bug has been identified: I think this bug existed since the first implementation. PR: Make sure users are signed in when clicking on managed cards #4255
• The offending PR has been commented on: Does this apply here? @MonilBhavsar
• A discussion in #expensify-bugs has been started: https://expensify.slack.com/archives/C049HHMV9SM/p1678747748363919

---

Regression Test Proposal

1. Have 2FA disabled on olddot
2. Set ENVIRONMENT=staging
3. Go to Settings > Workspaces > any workspace > Reimburse Expense > Click on "View all receipts"
4. Verify you're redirected to staging olddot i.e. staging.expensify.com
5. Go to Settings > Workspaces > any workspace > Pay Bills > Click on "View all bills"
6. Verify you're redirected to staging olddot i.e. staging.expensify.com
7. Go to Settings > Workspaces > any workspace > Send Invoices > Click on "Send Invoices" and "View all invoices"
8. Verify you're redirected to staging olddot i.e. staging.expensify.com
9. Go to Settings > Workspaces > any workspace > Connect bank account and start the process of setting up a bank account
10. Continue till Verifying state and confirm the 2FA prompt
11. Click on "Secure Account"
12. Verify you're redirected to staging olddot i.e. staging.expensify.com
13. Set ENVIRONMENT=production
14. Repeat steps 3-12 but instead Verify you're redirected to production olddot i.e. www.expensify.com

[MonilBhavsar]

The offending PR has been commented on: Does this apply here?

No, I don't think so it applies in this case. As it is not a regression, but something we missed during initial implementation. And it came to notice while testing the recent related PR.

[MonilBhavsar]

@s77rt thanks for regression steps. We already have some of this, so we just need to add to test on various environments

[MonilBhavsar]

@mallenexpensify, In the Workspace and Add Bank account section, we have tests to verify redirection to olddot is successful. Let's update those steps:

https://expensify.testrail.io/index.php?/cases/view/1971053&group_by=cases:section_id&group_order=asc&display_deleted_cases=0&group_id=229065

Web only
2. Verify you’re redirected to Expenses on the OldDot app in a new tab

2. Verify you’re redirected to Expenses on the corresponding OldDot app in a new tab. (Staging app redirects to staging.expensify.com and Production app redirects to expensify.com)

Similarly, we can update these tests too

https://expensify.testrail.io/index.php?/cases/view/1971055&group_by=cases:section_id&group_order=asc&display_deleted_cases=0&group_id=229065
https://expensify.testrail.io/index.php?/cases/view/1971057&group_by=cases:section_id&group_order=asc&display_deleted_cases=0&group_id=229065

[mallenexpensify]

Thanks @MonilBhavsar !
Created GH for TestRail Update https://github.com/Expensify/Expensify/issues/268630

[MonilBhavsar]

@mallenexpensify looks like we're good to issue payment here

[mallenexpensify]

Thanks for the ping @MonilBhavsar , sorry for the delay @s77rt, all paid!

[s77rt]

@mallenexpensify The reviewed PR introduced a regression. Shouldn't the payment be halved? The doc is not clear about such situations (for internal PRs)

[MonilBhavsar]

Oh yes, a regression was introduced for an offline case
cc @mallenexpensify

[mallenexpensify]

@s77rt and @MonilBhavsar . How would/should I, the BZ, know there was a regression here?

And yes, I believe your pay should be cut in half @s77rt , gonna wait a minute to pay.

[s77rt]

@mallenexpensify I have issued a 50% refund.
For regression, usually those are noted in the PR.

[mallenexpensify]

Thanks @s77rt !