Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove base constructor #2503

Merged
merged 1 commit into from
Feb 13, 2023
Merged

remove base constructor #2503

merged 1 commit into from
Feb 13, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Feb 9, 2023

Maybe works now

Signed-off-by: Rosen Penev [email protected]

@ghost
Copy link

ghost commented Feb 9, 2023

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #2503 (e7fdebb) into main (976dcd8) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2503      +/-   ##
==========================================
- Coverage   64.67%   64.67%   -0.01%     
==========================================
  Files         104      103       -1     
  Lines       22256    22254       -2     
  Branches    10863    10862       -1     
==========================================
- Hits        14394    14392       -2     
  Misses       5619     5619              
  Partials     2243     2243              
Impacted Files Coverage Δ
src/datasets.cpp 93.16% <ø> (-0.09%) ⬇️
src/properties.cpp 75.89% <100.00%> (ø)
src/tags.cpp 68.39% <100.00%> (ø)
include/exiv2/metadatum.hpp 78.57% <0.00%> (+1.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@neheb
Copy link
Collaborator Author

neheb commented Feb 9, 2023

even g++-7 compiles. Maybe was an issue with older MSVC. Or rule of 0 saves the day. Not sure.

Maybe works now

Signed-off-by: Rosen Penev <[email protected]>
@neheb neheb merged commit 31165b6 into Exiv2:main Feb 13, 2023
@neheb neheb deleted the c1 branch February 13, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants