Skip to content

Commit

Permalink
remove base constructor
Browse files Browse the repository at this point in the history
Maybe works now

Signed-off-by: Rosen Penev <[email protected]>
  • Loading branch information
neheb committed Feb 13, 2023
1 parent e1ac00a commit 31165b6
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 10 deletions.
5 changes: 0 additions & 5 deletions include/exiv2/datasets.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -256,11 +256,6 @@ class EXIV2API IptcKey : public Key {
@param record Record id
*/
IptcKey(uint16_t tag, uint16_t record);
//! Copy constructor
IptcKey(const IptcKey& rhs);
IptcKey& operator=(const IptcKey&) = default;
//! Destructor
~IptcKey() override = default;
//@}

//! @name Accessors
Expand Down
3 changes: 0 additions & 3 deletions src/datasets.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -508,9 +508,6 @@ IptcKey::IptcKey(uint16_t tag, uint16_t record) : tag_(tag), record_(record) {
makeKey();
}

IptcKey::IptcKey(const IptcKey& rhs) : Key(), tag_(rhs.tag_), record_(rhs.record_), key_(rhs.key_) {
}

std::string IptcKey::key() const {
return key_;
}
Expand Down
2 changes: 1 addition & 1 deletion src/properties.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5155,7 +5155,7 @@ XmpKey::XmpKey(const std::string& prefix, const std::string& property) : p_(std:

XmpKey::~XmpKey() = default;

XmpKey::XmpKey(const XmpKey& rhs) : Key(), p_(std::make_unique<Impl>(*rhs.p_)) {
XmpKey::XmpKey(const XmpKey& rhs) : p_(std::make_unique<Impl>(*rhs.p_)) {
}

XmpKey& XmpKey::operator=(const XmpKey& rhs) {
Expand Down
2 changes: 1 addition & 1 deletion src/tags.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ ExifKey::ExifKey(const std::string& key) : p_(std::make_unique<Impl>()) {
p_->decomposeKey(key);
}

ExifKey::ExifKey(const ExifKey& rhs) : Key(), p_(std::make_unique<Impl>(*rhs.p_)) {
ExifKey::ExifKey(const ExifKey& rhs) : p_(std::make_unique<Impl>(*rhs.p_)) {
}

ExifKey::~ExifKey() = default;
Expand Down

0 comments on commit 31165b6

Please sign in to comment.