Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernise code around iterators & smart pointers #2063

Merged
merged 8 commits into from
Feb 6, 2022
Merged

Modernise code around iterators & smart pointers #2063

merged 8 commits into from
Feb 6, 2022

Commits on Feb 5, 2022

  1. Use auto to reduce verbosity around code dealing with iterators

    @piponazo
    piponazo committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    9d8dd86 View commit details
    Browse the repository at this point in the history

  2. Add some TODO comments

    @piponazo
    piponazo committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    db4b639 View commit details
    Browse the repository at this point in the history

  3. Remove dead code

    @piponazo
    piponazo committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    d8732a7 View commit details
    Browse the repository at this point in the history

  4. Simplify code around UniquePtr(s) & use make_unique over new

    @piponazo
    piponazo committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    0f03e77 View commit details
    Browse the repository at this point in the history

  5. Fix build on linux

    @piponazo
    piponazo committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    b67dee8 View commit details
    Browse the repository at this point in the history

  6. Simplify cloning in actions

    @piponazo
    piponazo committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    d20f014 View commit details
    Browse the repository at this point in the history

  7. Modern implementation of Singleton 

    With this implementation we also make the initialization of the Singleton instance thread-safe
    @piponazo
    piponazo committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    f18d04c View commit details
    Browse the repository at this point in the history

  8. Simplify TaskFactory

    @piponazo
    piponazo committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    93fe208 View commit details
    Browse the repository at this point in the history