Modernise code around iterators & smart pointers #2063
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR my main objective was to cleanup some code around the iterators & smart pointers:
auto
when we are dealing with iterators since it makes the code much less verbose and without lossing clarity.std::make_unique
whenever possible when dealing with smart pointers. It reduces the amount of code and specially it avoids the usage ofnew
anddelete
. This follows one of the rules in the C++ Core guidelines.