Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update canonmn_int.cpp to correct lens "Canon EF 80-200mm f/4.5-5.6 II" #1932

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

John55h
Copy link
Contributor

@John55h John55h commented Sep 27, 2021

This PR corrects exiv2 lens identification for "Canon EF 80-200mm f/4.5-5.6 II"
Canon Exif.CanonCs.LensType IDs 28 and 38 both get reported as Canon EF 80-200mm f/4.5-5.6

See: #1906

I have raised an issue with lensfun to correct their database and consider how they determine the lens from the metadata which Exiv2 parses correctly.
lensfun/lensfun#1484

Correct Exif.CanonCs.LensType 38 for "Canon EF 80-200mm f/4.5-5.6 II"
@kmilos
Copy link
Collaborator

kmilos commented Sep 27, 2021

Thanks!

@kmilos kmilos added bug lens Issue related to lens detection prettyPrinter Anything related to the output formatting of a value labels Sep 27, 2021
@kmilos kmilos added this to the v1.00 milestone Sep 27, 2021
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #1932 (a8ec0b0) into main (b27aa0b) will not change coverage.
The diff coverage is n/a.

❗ Current head a8ec0b0 differs from pull request most recent head 02d4073. Consider uploading reports for the commit 02d4073 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1932   +/-   ##
=======================================
  Coverage   61.13%   61.13%           
=======================================
  Files          96       96           
  Lines       19059    19059           
  Branches     9734     9734           
=======================================
  Hits        11651    11651           
  Misses       5092     5092           
  Partials     2316     2316           
Impacted Files Coverage Δ
src/canonmn_int.cpp 64.51% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b27aa0b...02d4073. Read the comment docs.

@kmilos kmilos removed this from the v1.00 milestone Sep 27, 2021
@kmilos
Copy link
Collaborator

kmilos commented Sep 27, 2021

IMHO should be ok to backport to 0.27.5 as well...

@kevinbackhouse kevinbackhouse added this to the v1.00 milestone Sep 27, 2021
@kevinbackhouse
Copy link
Collaborator

@kmilos: I have no objection to back-porting this. We might want to check what @clanmills thinks though. Just add a comment like this one to back-port.

@kevinbackhouse kevinbackhouse merged commit 7bd1935 into Exiv2:main Sep 29, 2021
@clanmills
Copy link
Collaborator

@kmilos, @kevinbackhouse, @John55h Thank You for working on this. Please submit a PR to branch 0.27-maintenance for this change to be included in v0.27.5 RC3 which I plan to build and release on 2021-09-30.

@kevinbackhouse
Copy link
Collaborator

@Mergifyio backport 0.27-maintenance

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2021

Command backport 0.27-maintenance: success

Backports have been created

kevinbackhouse added a commit that referenced this pull request Sep 29, 2021
Update canonmn_int.cpp to correct lens "Canon EF 80-200mm f/4.5-5.6 II" (backport #1932)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug lens Issue related to lens detection prettyPrinter Anything related to the output formatting of a value
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Canon EF 80-200mm f/4.5-5.6 II" identified as "Canon EF 80-200mm f/4.5-5.6"
4 participants