-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update canonmn_int.cpp to correct lens "Canon EF 80-200mm f/4.5-5.6 II" #1932
Conversation
Correct Exif.CanonCs.LensType 38 for "Canon EF 80-200mm f/4.5-5.6 II"
Thanks! |
Codecov Report
@@ Coverage Diff @@
## main #1932 +/- ##
=======================================
Coverage 61.13% 61.13%
=======================================
Files 96 96
Lines 19059 19059
Branches 9734 9734
=======================================
Hits 11651 11651
Misses 5092 5092
Partials 2316 2316
Continue to review full report at Codecov.
|
IMHO should be ok to backport to 0.27.5 as well... |
@kmilos: I have no objection to back-porting this. We might want to check what @clanmills thinks though. Just add a comment like this one to back-port. |
@kmilos, @kevinbackhouse, @John55h Thank You for working on this. Please submit a PR to branch 0.27-maintenance for this change to be included in v0.27.5 RC3 which I plan to build and release on 2021-09-30. |
@Mergifyio backport 0.27-maintenance |
Command
|
Update canonmn_int.cpp to correct lens "Canon EF 80-200mm f/4.5-5.6 II" (backport #1932)
This PR corrects exiv2 lens identification for "Canon EF 80-200mm f/4.5-5.6 II"
Canon Exif.CanonCs.LensType IDs 28 and 38 both get reported as Canon EF 80-200mm f/4.5-5.6
See: #1906
I have raised an issue with lensfun to correct their database and consider how they determine the lens from the metadata which Exiv2 parses correctly.
lensfun/lensfun#1484