Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calibration for "Canon EF 80-200mm f/4.5-5.6 II" identified as "Canon EF 80-200mm f/4.5-5.6" #1484

Closed
John55h opened this issue Sep 27, 2021 · 2 comments

Comments

@John55h
Copy link

John55h commented Sep 27, 2021

Calibration for "Canon EF 80-200mm f/4.5-5.6 II" is labelled "Canon EF 80-200mm f/4.5-5.6"
(Uploaded in #1173)
The lensfun calibration appears to be using exiv2 Exif.CanonCs.LensType (an integer from exif tag) as the lens identifier. This resulting string is made up (by exiv2). Unfortunately both exiv2 and exiftool report an identical string for LensType 28 and 38 ("Canon EF 80-200mm f/4.5-5.6" is 28 and "Canon EF 80-200mm f/4.5-5.6 II" is 38).

$ exiv2 -pt  IMG_9824.jpg |grep -ai lens
Exif.CanonCs.LensType                        Short       1  Canon EF 80-200mm f/4.5-5.6
Exif.CanonCs.Lens                            Short       3  80.0 - 200.0 mm
Exif.Canon.LensModel                         Ascii      70  EF80-200mm f/4.5-5.6 II
Exif.Photo.LensSpecification                 Rational    4  80/1 200/1 0/0 0/0
Exif.Photo.LensModel                         Ascii      70  EF80-200mm f/4.5-5.6 II
Exif.Photo.LensSerialNumber                  Ascii      12  0000000000'

If the lens data is really for version II of the lens the database entry should indicate that.

Going forward it would be better to use the following tags in the priority order below:
Exif.Photo.LensModel (Canon string from Exif 2.32)
Exif.Canon.LensModel (Canon string from makernote)
Exif.CanonCs.LensType (integer translated to a string by exiv2)

Please see: Exiv2/exiv2#1906 (comment) for a more detailed explanation of the exif tags involved.

@tuxfanx
Copy link
Contributor

tuxfanx commented Aug 26, 2022

Unfortunately, the uploaded pictures are no longer available and I couldn't find any on the internet either. Could you upload a raw image here for a test?

@tuxfanx
Copy link
Contributor

tuxfanx commented Dec 30, 2022

no pictures uploaded. Exiv2 should be corrected.

@tuxfanx tuxfanx closed this as completed Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants