You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Calibration for "Canon EF 80-200mm f/4.5-5.6 II" is labelled "Canon EF 80-200mm f/4.5-5.6"
(Uploaded in #1173)
The lensfun calibration appears to be using exiv2 Exif.CanonCs.LensType (an integer from exif tag) as the lens identifier. This resulting string is made up (by exiv2). Unfortunately both exiv2 and exiftool report an identical string for LensType 28 and 38 ("Canon EF 80-200mm f/4.5-5.6" is 28 and "Canon EF 80-200mm f/4.5-5.6 II" is 38).
$ exiv2 -pt IMG_9824.jpg |grep -ai lens
Exif.CanonCs.LensType Short 1 Canon EF 80-200mm f/4.5-5.6
Exif.CanonCs.Lens Short 3 80.0 - 200.0 mm
Exif.Canon.LensModel Ascii 70 EF80-200mm f/4.5-5.6 II
Exif.Photo.LensSpecification Rational 4 80/1 200/1 0/0 0/0
Exif.Photo.LensModel Ascii 70 EF80-200mm f/4.5-5.6 II
Exif.Photo.LensSerialNumber Ascii 12 0000000000'
If the lens data is really for version II of the lens the database entry should indicate that.
Going forward it would be better to use the following tags in the priority order below:
Exif.Photo.LensModel (Canon string from Exif 2.32)
Exif.Canon.LensModel (Canon string from makernote)
Exif.CanonCs.LensType (integer translated to a string by exiv2)
Unfortunately, the uploaded pictures are no longer available and I couldn't find any on the internet either. Could you upload a raw image here for a test?
Calibration for "Canon EF 80-200mm f/4.5-5.6 II" is labelled "Canon EF 80-200mm f/4.5-5.6"
(Uploaded in #1173)
The lensfun calibration appears to be using exiv2 Exif.CanonCs.LensType (an integer from exif tag) as the lens identifier. This resulting string is made up (by exiv2). Unfortunately both exiv2 and exiftool report an identical string for LensType 28 and 38 ("Canon EF 80-200mm f/4.5-5.6" is 28 and "Canon EF 80-200mm f/4.5-5.6 II" is 38).
If the lens data is really for version II of the lens the database entry should indicate that.
Going forward it would be better to use the following tags in the priority order below:
Exif.Photo.LensModel (Canon string from Exif 2.32)
Exif.Canon.LensModel (Canon string from makernote)
Exif.CanonCs.LensType (integer translated to a string by exiv2)
Please see: Exiv2/exiv2#1906 (comment) for a more detailed explanation of the exif tags involved.
The text was updated successfully, but these errors were encountered: