cmake/compilerFlags.cmake: properly detect availability of flags #1252
Conversation
Instead of relying on fragile and complex logic to decide if a compiler flag is available or not, use the check_c_compiler_flag() macro provided by the CMake standard library. This for example avoids using -fcf-protection on architectures that don't support this option. Signed-off-by: Thomas Petazzoni <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1252 +/- ##
=======================================
Coverage 71.91% 71.91%
=======================================
Files 152 152
Lines 17674 17674
=======================================
Hits 12710 12710
Misses 4964 4964 Continue to review full report at Codecov.
|
|
It is possible to do a similar change in 0.27-maintenance. By co-incidence @ryandesign asked for this to be done to support MacPorts. I was unsuccessful when I tried to do this with #1245. My dyslexia got the better of me. I find this kind of change very difficult to get right. As you can see, Ryan gave me a detailed review, however I thought I'd probably make matters worse when I try to fix my mistakes. However, I did set up a Yosemite VM with Xcode 6.1. So, I'm happy to test anybody's PR to address this. |
…xiv2#1252) Instead of relying on fragile and complex logic to decide if a compiler flag is available or not, use the check_c_compiler_flag() macro provided by the CMake standard library. This for example avoids using -fcf-protection on architectures that don't support this option. Signed-off-by: Thomas Petazzoni <[email protected]> (cherry picked from commit dd2d181) When resolving the conflict from applying the patch, I also took the liberty of re-indenting the snippet correcly and fixing mismatching HAS_FCF_PROTECTION and HAS_FSTACK_PROTECTOR_STRONG variables (the conditionals used GCC_ prefix but the variables were definded without it). Signed-off-by: Jan Tojnar <[email protected]>
|
I cherry picked this over to 0.27 branch: #1271 |
Properly detect availability of flags in cmake/compilerFlags.cmake (#1252)
Instead of relying on fragile and complex logic to decide if a
compiler flag is available or not, use the check_c_compiler_flag()
macro provided by the CMake standard library.
This for example avoids using -fcf-protection on architectures that
don't support this option.
Signed-off-by: Thomas Petazzoni [email protected]