Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on aarch64 #1238

Closed
wants to merge 1 commit into from
Closed

Conversation

hfiguiere
Copy link

  • This is a followup to commit 1ea63cc

This is the patch I used for the flatpak builds of Rawtherapee and Entangle

This does not mean other non-x86_64 builds will work. (it's the only arch with maybe i386 that supports it right now according to the documentation). Ideally this should be checked by checking if the compiler supports it.

- This is a followup to commit 1ea63cc
@clanmills
Copy link
Collaborator

I think we're pursuing a different direction with this issue. @ryandesign is the engineer maintaining Exiv2 on MacPorts and he requested changes to enable the latest code to build on with Xcode 6. #1243

I attempted to use the CMake command CHECK_C_COMPILER_FLAG on every compiler option. Although this makes the CMake code longer, it's simpler. I submitted a PR #1245. Sadly, the PR has numerous errors due my dyslexia. @ryandesign agreed to update the PR. I've set up a Xcode 6.1 on Yosemite to test this for MacPorts.

Can we wait for #1245 to merge and decide the simplest way to deal with your request. Remarkably, I've had requests to support ARM and PPC in the last few weeks and currently have no way to test them. I would very much appreciate help with testing this stuff.

Another important point is that I manage the 0.27-maintenance branch and never submit code to 'master'. If we get this sorted out on 0.27-maintenance, I hope another contributor will port the changes to 'master'.

I'm hoping that 'master' will be released as Exiv2 v0.28 later this year and have offered to be the release engineer for that project. I've received no response to my offer.

@tbeu
Copy link
Member

tbeu commented Aug 10, 2020

@hfiguiere Can you please confirm that #1252 resolved the issue (for aarch64, too)?

@tbeu tbeu added the CMake Configuration issues related with CMake label Aug 10, 2020
@hfiguiere
Copy link
Author

@hfiguiere Can you please confirm that #1252 resolved the issue (for aarch64, too)?

it does. thanks !

@tbeu tbeu added the duplicate label Aug 12, 2020
@tbeu tbeu closed this Aug 12, 2020
@hfiguiere hfiguiere deleted the non-x86_64-build branch October 11, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake Configuration issues related with CMake duplicate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants