Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unifying/improving spelling of names within the PaNET ontology #150

Open
kara-mela opened this issue Aug 9, 2024 · 0 comments
Open

unifying/improving spelling of names within the PaNET ontology #150

kara-mela opened this issue Aug 9, 2024 · 0 comments

Comments

@kara-mela
Copy link

I recognized that the terminology in PaNET is already widely unified, however I discovered some exceptions. It would be great if you could have a look at it:

  1. ‘spin echo scattering’ -> additional space between echo and scattering
  2. 'high resolution' is spelled without dash in almost all cases, except for 'high resolution neutron imaging'
  3. some few names with abbreviations, please avoid
  • EUV -> extreme ultra violet, UV -> ultra violet, VUV -> vacuum ultra violet
  • 'IR photon probe' is the only case where IR is used instead of infrared
  • 'time of flight' is the generally used spelling, exceptions are 'pulsed neutron TOF probe' and 'time-of-flight spectrometry'
  • XMCD -> 'x-ray magnetic circular dichroism'

I accidentally created that issue previously within the wrong project: ExPaNDS-eu/ExPaNDS#55
kara-mela added a commit to kara-mela/ExPaNDS-experimental-techniques-ontology that referenced this issue Aug 9, 2024
@kara-mela
Partially solving Issue ExPaNDS-eu#150: spin echo scattering
e4ac96b 
Motivation

In order to improve the spelling, I suggest to delete the additional space in 'spin echo  scattering', PaNET01119.

Modification

Deleting this space directly affects the label of PaNET01119. Additionally this requires changing the spelling when this technique is used as Parent IRI in PaNET01120, PaNET01126, and PaNET01127.

Result

The ontology does not contain double spaces anymore. The test with panet-build was successful. The test with panet-build was successful.
kara-mela added a commit to kara-mela/ExPaNDS-experimental-techniques-ontology that referenced this issue Aug 9, 2024
@kara-mela
Partially solving Issue ExPaNDS-eu#150: high resolution neutron imaging
35815d9 
Motivation

In order to unify the spelling, I suggest to be consistent in the use of dash or space when using 'high resolution'. Only the term 'high resolution neutron imaging' (PaNET01250) is using a dash currently.

Modification

Exchanging the dash with a space in 'high resolution neutron imaging' (PaNET01250). No further terms are affected by that change

Result

The notation of 'high resolution' is now unique within the ontology.
kara-mela added a commit to kara-mela/ExPaNDS-experimental-techniques-ontology that referenced this issue Aug 9, 2024
@kara-mela
Partially solving Issue ExPaNDS-eu#150: infrared
01740b1 
Motivation

In order to unify the spelling, I suggest to be consistent in writing 'infrared'/'IR'. Only the term 'IR photon probe' (PaNET01005) solely contains the abbreviation, but does not have a (Alt) Label that is written in full.

Modification

'infrared photon probe' is now the Label of PaNET01005, with the Alt Label 'IR photon probe'. This induces changes of the Parent IRI in PaNET01109, PaNET01175, and PaNET01778.

Result

The notation of 'infrared' is consistent within the ontology. The test with panet-build was successful.
kara-mela added a commit to kara-mela/ExPaNDS-experimental-techniques-ontology that referenced this issue Aug 9, 2024
@kara-mela
Partially solving Issue ExPaNDS-eu#150: time of flight
d370ad6 
Motivation

In order to unify the spelling, I suggest to be consistent in writing 'TOF'/'time-of-flight'/'time of flight'. Only the term 'time-of-flight spectrometry' (PaNET1244) uses dashes. Only the term 'pulsed neutron TOF probe' (PaNET01019) solely uses 'TOF' without having an Alt Label with the fully written term.

Modification

The Label of PaNET1244 is now 'time of flight spectrometry'. The Label of PaNET01019 is now 'pulsed neutron time of flight probe' with the Alt Label 'pulsed neutron TOF probe'. No further changes are induced.

Result

The notation of 'time of flight' is consistent within the ontology. The test with panet-build was successful.
kara-mela added a commit to kara-mela/ExPaNDS-experimental-techniques-ontology that referenced this issue Aug 9, 2024
@kara-mela
Partially solving Issue ExPaNDS-eu#150: XMCD
b743121 
Motivation

In order to improve spelling, I suggest to add the label in natural language of 'xmcd' subclass PaNET01221, which is currently missing.

Modification

The Label of PaNET01221 is now 'x-ray magnetic circular dichroism total electron yield', the previous Label 'XMCD total electron yield' is now used as Alt Label. No further changes were induced.

Result

The notation of PaNET01221 now has a representation in natural language. The test with panet-build was successful.
kara-mela added a commit to kara-mela/ExPaNDS-experimental-techniques-ontology that referenced this issue Aug 9, 2024
@kara-mela
Partially solving Issue ExPaNDS-eu#150: UV, VUV, EUV
ba1cce3 
Motivation

In order to improve the spelling, I suggest to add a description in natural language to all UV, EUV, and VUV terms (ultra violet, extreme ultra violet, and vacuum ultra violet, respectively).

Modification

Changes were made on the following PaNET terms: PaNET01007, PaNET01008, PaNET001009, PaNET01010, PaNET01011, PaNET01130, PaNET01131, PaNET01132, PaNET01176, PaNET01225, PaNET01257. For almost all term, the changes concern all three columns Label, Alt Label, and Parent IRI. Exceptions are PaNET01007, where a change of Parent IRI was not needed. Further PaNET01008 inherits from PaNET01007, but its Label and Alt Label do not include critical terms.

 Finally, the direct changes had a negative effect on the readability of PaNET01130, therefore I decided to add a slash: 'ultra violet / vacuum ultra violet spectroscopy'.

Result

The representatives of UV, EUV, and VUV techniques now all have a representation in natural language. The test with panet-build was successful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kara-mela