Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connect): support DdlParse #3580

Merged
merged 5 commits into from
Dec 17, 2024

add disclaimer

dc20be8
Select commit
Loading
Failed to load commit list.
Merged

feat(connect): support DdlParse #3580

add disclaimer
dc20be8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 16, 2024 in 0s

77.84% (+0.04%) compared to 6c21917

View this Pull Request on Codecov

77.84% (+0.04%) compared to 6c21917

Details

Codecov Report

Attention: Patch coverage is 95.78947% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.84%. Comparing base (6c21917) to head (dc20be8).

Files with missing lines Patch % Lines
src/daft-connect/src/lib.rs 90.00% 2 Missing ⚠️
src/daft-sql/src/planner.rs 97.18% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3580      +/-   ##
==========================================
+ Coverage   77.79%   77.84%   +0.04%     
==========================================
  Files         716      716              
  Lines       87991    88083      +92     
==========================================
+ Hits        68455    68568     +113     
+ Misses      19536    19515      -21     
Files with missing lines Coverage Δ
src/daft-schema/src/schema.rs 94.42% <100.00%> (+2.11%) ⬆️
src/daft-sql/src/lib.rs 100.00% <ø> (ø)
src/daft-connect/src/lib.rs 70.74% <90.00%> (+2.17%) ⬆️
src/daft-sql/src/planner.rs 73.88% <97.18%> (+1.10%) ⬆️

... and 8 files with indirect coverage changes