Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connect): support DdlParse #3580

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

andrewgazelka
Copy link
Contributor

No description provided.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Dec 16, 2024

CodSpeed Performance Report

Merging #3580 will degrade performances by 17.03%

Comparing 12-16-feat_connect_support_ddlparse_ (eba4b4f) with main (e148248)

Summary

❌ 1 regressions
✅ 26 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 12-16-feat_connect_support_ddlparse_ Change
test_iter_rows_first_row[100 Small Files] 142.9 ms 172.3 ms -17.03%

@andrewgazelka andrewgazelka marked this pull request as ready for review December 16, 2024 21:24
@andrewgazelka andrewgazelka force-pushed the 12-16-feat_connect_support_ddlparse_ branch from 4c60c54 to 1cc57ca Compare December 16, 2024 21:42
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 72.63158% with 26 lines in your changes missing coverage. Please review.

Project coverage is 77.82%. Comparing base (6c21917) to head (eba4b4f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-connect/src/lib.rs 0.00% 20 Missing ⚠️
src/daft-schema/src/schema.rs 0.00% 4 Missing ⚠️
src/daft-sql/src/planner.rs 97.18% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3580      +/-   ##
==========================================
+ Coverage   77.79%   77.82%   +0.02%     
==========================================
  Files         716      716              
  Lines       87991    88337     +346     
==========================================
+ Hits        68455    68748     +293     
- Misses      19536    19589      +53     
Files with missing lines Coverage Δ
src/daft-sql/src/lib.rs 100.00% <ø> (ø)
src/daft-sql/src/planner.rs 73.88% <97.18%> (+1.10%) ⬆️
src/daft-schema/src/schema.rs 92.82% <0.00%> (+0.52%) ⬆️
src/daft-connect/src/lib.rs 62.88% <0.00%> (-5.69%) ⬇️

... and 9 files with indirect coverage changes

Copy link
Contributor

@universalmind303 universalmind303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewgazelka once the test is updated, i think we can merge this in.

@andrewgazelka andrewgazelka enabled auto-merge (squash) December 17, 2024 19:39
@andrewgazelka andrewgazelka merged commit 47f5897 into main Dec 17, 2024
41 of 42 checks passed
@andrewgazelka andrewgazelka deleted the 12-16-feat_connect_support_ddlparse_ branch December 17, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants