Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connect): add df.{intersection,union} #3373

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrewgazelka
Copy link
Contributor

No description provided.

Copy link
Contributor Author

andrewgazelka commented Nov 21, 2024

@andrewgazelka andrewgazelka force-pushed the andrew/connect-with_column branch from 4947388 to 6c483e4 Compare November 21, 2024 00:14
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from 38df2b4 to c0bac90 Compare November 21, 2024 00:14
@andrewgazelka andrewgazelka marked this pull request as ready for review November 21, 2024 00:17
@andrewgazelka andrewgazelka force-pushed the andrew/connect-with_column branch from 6c483e4 to 1d982a4 Compare November 21, 2024 00:39
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from c0bac90 to da9ae04 Compare November 21, 2024 00:40
Copy link

graphite-app bot commented Nov 21, 2024

Graphite Automations

"Warn authors when publishing large PRs" took an action on this PR • (11/21/24)

1 teammate was notified to this PR based on Andrew Gazelka's automation.

@andrewgazelka andrewgazelka force-pushed the andrew/connect-with_column branch from 1d982a4 to e2964bb Compare November 21, 2024 01:45
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from da9ae04 to 2d48b32 Compare November 21, 2024 01:45
@andrewgazelka andrewgazelka force-pushed the andrew/connect-with_column branch from e2964bb to 1995cf4 Compare November 21, 2024 01:50
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from 2d48b32 to 9711e2c Compare November 21, 2024 01:50
@andrewgazelka andrewgazelka force-pushed the andrew/connect-with_column branch from 1995cf4 to 1ec1514 Compare November 21, 2024 03:22
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from 9711e2c to 73c5c9b Compare November 21, 2024 03:22
@andrewgazelka andrewgazelka force-pushed the andrew/connect-with_column branch from 1ec1514 to d56345b Compare November 21, 2024 04:19
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from 73c5c9b to c026db1 Compare November 21, 2024 04:19
@andrewgazelka andrewgazelka force-pushed the andrew/connect-with_column branch from d56345b to 91be0c5 Compare November 21, 2024 04:23
@andrewgazelka andrewgazelka force-pushed the andrew/connect-with_column branch from d56345b to 60d2451 Compare November 21, 2024 05:17
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from c026db1 to e4dadeb Compare November 21, 2024 05:17
@andrewgazelka andrewgazelka force-pushed the andrew/connect-with_column branch from 60d2451 to e4dd45f Compare November 21, 2024 05:17
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from e4dadeb to 9bcb827 Compare November 21, 2024 05:18
@andrewgazelka andrewgazelka force-pushed the andrew/connect-with_column branch from e4dd45f to c49d8d6 Compare November 21, 2024 16:57
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from 9bcb827 to 886d014 Compare November 21, 2024 16:57
@andrewgazelka andrewgazelka force-pushed the andrew/connect-with_column branch from c25eb08 to 09cb106 Compare December 5, 2024 18:28
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from 8fcea97 to 3038c0f Compare December 5, 2024 18:28
Base automatically changed from andrew/connect-with_column to main December 5, 2024 21:39
@github-actions github-actions bot added the enhancement New feature or request label Dec 5, 2024
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from 3038c0f to 31e8bc8 Compare December 5, 2024 21:40
Copy link

codspeed-hq bot commented Dec 5, 2024

CodSpeed Performance Report

Merging #3373 will degrade performances by 44.81%

Comparing andrew/connect-intersect-union (4ed9161) with main (07752b8)

Summary

❌ 2 regressions
✅ 25 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andrew/connect-intersect-union Change
test_iter_rows_first_row[100 Small Files] 159.5 ms 289 ms -44.81%
test_show[100 Small Files] 16.1 ms 23.2 ms -30.52%

@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from 6f43372 to 8efe7d7 Compare December 5, 2024 21:53
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.90%. Comparing base (07752b8) to head (4ed9161).

Files with missing lines Patch % Lines
...aft-connect/src/translation/logical_plan/set_op.rs 83.72% 7 Missing ⚠️
src/daft-connect/src/translation/logical_plan.rs 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3373      +/-   ##
==========================================
+ Coverage   77.86%   77.90%   +0.04%     
==========================================
  Files         719      720       +1     
  Lines       88459    88505      +46     
==========================================
+ Hits        68877    68949      +72     
+ Misses      19582    19556      -26     
Files with missing lines Coverage Δ
src/daft-connect/src/translation/logical_plan.rs 68.85% <66.66%> (-0.12%) ⬇️
...aft-connect/src/translation/logical_plan/set_op.rs 83.72% <83.72%> (ø)

... and 5 files with indirect coverage changes

@andrewgazelka andrewgazelka marked this pull request as ready for review December 5, 2024 22:45
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from 8efe7d7 to b7848ce Compare December 9, 2024 22:09
@andrewgazelka andrewgazelka changed the title [FEAT] connect: add df.{intersection,union} feat(connect): add df.{intersection,union} Dec 10, 2024
@github-actions github-actions bot added the feat label Dec 10, 2024
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from b7848ce to 0de7b03 Compare December 10, 2024 01:51
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch 4 times, most recently from f2a1799 to 11fefd5 Compare December 11, 2024 21:06
@andrewgazelka andrewgazelka marked this pull request as draft December 11, 2024 21:20
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch 4 times, most recently from 6508d07 to 4ed9161 Compare December 18, 2024 19:16
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch 3 times, most recently from f28dfd4 to dcdcdbd Compare December 19, 2024 10:14
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from dcdcdbd to 1e96247 Compare December 19, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants