Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] consolidate Spark session fixture into conftest.py #3341

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

andrewgazelka
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Nov 20, 2024
Copy link
Contributor Author

andrewgazelka commented Nov 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@andrewgazelka andrewgazelka marked this pull request as ready for review November 20, 2024 03:49
Copy link

codspeed-hq bot commented Nov 20, 2024

CodSpeed Performance Report

Merging #3341 will degrade performances by 31.95%

Comparing andrew/connect-consolidate-session (008b377) with main (ec24c80)

Summary

❌ 1 regressions
✅ 16 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andrew/connect-consolidate-session Change
test_iter_rows_first_row[100 Small Files] 192.3 ms 282.6 ms -31.95%

@universalmind303 universalmind303 self-requested a review November 20, 2024 16:38
@andrewgazelka andrewgazelka force-pushed the andrew/connect-consolidate-session branch from 74bd79b to cfd62bd Compare November 20, 2024 18:24
@andrewgazelka andrewgazelka force-pushed the andrew/connect-consolidate-session branch 2 times, most recently from 92b5258 to 98a1b86 Compare November 20, 2024 18:48
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.42%. Comparing base (ec24c80) to head (008b377).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-connect/src/lib.rs 85.18% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3341   +/-   ##
=======================================
  Coverage   77.41%   77.42%           
=======================================
  Files         678      678           
  Lines       83216    83233   +17     
=======================================
+ Hits        64423    64441   +18     
+ Misses      18793    18792    -1     
Files with missing lines Coverage Δ
src/daft-connect/src/lib.rs 49.75% <85.18%> (+3.47%) ⬆️

... and 2 files with indirect coverage changes

---- 🚨 Try these New Features:

@andrewgazelka andrewgazelka force-pushed the andrew/connect-consolidate-session branch from 98a1b86 to 008b377 Compare November 20, 2024 19:31
@andrewgazelka andrewgazelka enabled auto-merge (squash) November 20, 2024 19:40
@andrewgazelka andrewgazelka merged commit bdfb8c6 into main Nov 20, 2024
42 of 43 checks passed
@andrewgazelka andrewgazelka deleted the andrew/connect-consolidate-session branch November 20, 2024 19:52
Copy link
Contributor Author

andrewgazelka commented Nov 21, 2024

Merge activity

  • Nov 20, 7:38 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 21, 11:41 AM EST: A user started a stack merge that includes this pull request via Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants