Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix ray wait in RayPartitionSet #3251

Merged
merged 1 commit into from
Nov 15, 2024
Merged

[BUG] Fix ray wait in RayPartitionSet #3251

merged 1 commit into from
Nov 15, 2024

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Nov 8, 2024

Closes: #3249

Ray's ray.wait is supposed to:

  1. Defaults to fetch_local=True which will supposedly fetch data to wherever the wait is called before returning
  2. Defaults to num_returns=1 which will wait until only the first item is ready before returning

This seems to not be the intended behavior here, where RayPartitionSet is trying to wait on ALL the partitions to be ready, and does not want to pull any data down to the calling site.

@github-actions github-actions bot added the bug Something isn't working label Nov 8, 2024
Copy link

codspeed-hq bot commented Nov 8, 2024

CodSpeed Performance Report

Merging #3251 will degrade performances by 26.78%

Comparing jay/wait-no-local (a3ede70) with main (f566125)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main jay/wait-no-local Change
test_count[1 Small File] 3.2 ms 4.1 ms -22.24%
test_iter_rows_first_row[100 Small Files] 358.8 ms 283.5 ms +26.57%
test_show[100 Small Files] 24 ms 32.8 ms -26.78%

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.86%. Comparing base (f566125) to head (a3ede70).
Report is 41 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3251   +/-   ##
=======================================
  Coverage   77.86%   77.86%           
=======================================
  Files         643      643           
  Lines       79558    79558           
=======================================
  Hits        61947    61947           
  Misses      17611    17611           
Files with missing lines Coverage Δ
daft/runners/ray_runner.py 81.01% <100.00%> (ø)

... and 1 file with indirect coverage changes

@jaychia jaychia requested a review from colin-ho November 14, 2024 18:13
@jaychia jaychia merged commit 84db665 into main Nov 15, 2024
45 of 46 checks passed
@jaychia jaychia deleted the jay/wait-no-local branch November 15, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not wait on Ray object refs to be fetched locally during a collect
2 participants