Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not wait on Ray object refs to be fetched locally during a collect #3249

Closed
jaychia opened this issue Nov 8, 2024 · 0 comments · Fixed by #3251
Closed

Do not wait on Ray object refs to be fetched locally during a collect #3249

jaychia opened this issue Nov 8, 2024 · 0 comments · Fixed by #3251
Labels
bug Something isn't working needs triage

Comments

@jaychia
Copy link
Contributor

jaychia commented Nov 8, 2024

Describe the bug

I think this is a pretty serious problem? Not quite sure though.

According to docs, ray.wait by default will fetch data to the local node before returning. I don't think the intention here in this line of code is to do that!

def wait(self) -> None:
deduped_object_refs = {r.partition() for r in self._results.values()}
ray.wait(list(deduped_object_refs))

image

To Reproduce

No response

Expected behavior

No response

Component(s)

Ray Runner

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant