Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DONE] Fix Typo #1225 #1235

Merged
merged 5 commits into from
Jan 22, 2025
Merged

[DONE] Fix Typo #1225 #1235

merged 5 commits into from
Jan 22, 2025

Conversation

Badatos
Copy link
Collaborator

@Badatos Badatos commented Dec 11, 2024 •
edited
Loading

  • Fix Typo  #1225
  • replace generic i18n strings by named dict

@Badatos
Fix Typo EsupPortail#1225
ef486d5 
+ replace generic i18n strings by named dict
@Badatos Badatos self-assigned this Dec 11, 2024
@Badatos Badatos requested a review from LoicBonavent December 11, 2024 15:41
@Badatos Badatos linked an issue Dec 11, 2024 that may be closed by this pull request
Typo #1225
Closed
LoicBonavent
LoicBonavent reviewed Dec 12, 2024
View reviewed changes
pod/locale/fr/LC_MESSAGES/django.po
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est vrai que j'utilise régulièrement %s, par défaut. Je ferai attention à changer cette habitude pour la v4 :)

LoicBonavent
LoicBonavent approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@LoicBonavent LoicBonavent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faut pas nous habituer à de si petites PR :)
Nickel, merci Olivier

@Badatos Badatos requested a review from Naihl January 21, 2025 15:04
@Badatos Badatos merged commit 3fd40aa into EsupPortail:develop Jan 22, 2025
2 checks passed
@Badatos Badatos deleted the fix-Typo-1225 branch January 22, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naihl Naihl Naihl approved these changes

@LoicBonavent LoicBonavent LoicBonavent approved these changes

Assignees

@Badatos Badatos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo
3 participants
@Badatos @LoicBonavent @Naihl