fix(calcite-button): Make shadow dom button 100% width #9145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
alisonailea
approved these changes
Apr 18, 2024
| :host([scale="l"][width="full"]) button:not(.content--slotted), | ||
| :host([scale="l"][width="full"]) a:not(.content--slotted) { | ||
| @apply w-full; | ||
| } |
There was a problem hiding this comment.
alternative approach
:host(:is([scale="s"], [scale="m"], [scale="l"])[width="full"]) {
a, button {
&:not(.content--slotted) {
inline-size: var(--calcite-container-size-content-fluid);
}
}
}
There was a problem hiding this comment.
Another alternative approach would be to apply a class here using JS since the CSS logic is getting a little complex here.
driskull
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Code looks good! @josercarcamo is this fix captured in a screenshot test? If not can we add one?
6 tasks
driskull
added
the
pr ready for visual snapshots
…com:Esri/calcite-design-system into josercarcamo/8490-calcite-button-shadow-dom
josercarcamo
added
pr ready for visual snapshots
github-actions
bot
added this to the 2024-05-09 - 1.8.1 May maintenance release milestone
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #8490
Summary
When the host element button is set to "full" the shadow dom button is set to 100% width to span the entire space.