Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown button trigger is not truncating #9149

Open
2 of 6 tasks
tyanthony opened this issue Apr 18, 2024 · 10 comments
Open
2 of 6 tasks

Dropdown button trigger is not truncating #9149

tyanthony opened this issue Apr 18, 2024 · 10 comments
Labels
ArcGIS Mission Issues logged by ArcGIS Mission team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - medium Issue is non core or affecting less that 60% of people using the library spike complete Issues that have a research spike completed and dev work can proceed

Comments

@tyanthony
Copy link

Check existing issues

Actual Behavior

A dropdown's button trigger does not truncate as expected but the content is constrained.

Expected Behavior

The button should truncate when necessary for a dropdown's trigger.

Reproduction Sample

https://codepen.io/tyleranthony/pen/eYoPzzP?editors=1100

Reproduction Steps

  1. Add a Dropdown with a Button as the trigger and some other content
  2. Set the container of those to a specified width
  3. notice that the dropdown's button does not truncate

Reproduction Version

2.7.1

Relevant Info

Noticed on Chrome

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Impact

This pushes content off the page making is inaccessible.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Mission

@tyanthony tyanthony added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Apr 18, 2024
@github-actions github-actions bot added ArcGIS Mission Issues logged by ArcGIS Mission team members. calcite-components Issues specific to the @esri/calcite-components package. p3 - want for upcoming milestone labels Apr 18, 2024
@geospatialem geospatialem added the blocked This issue is blocked by another issue. label Apr 29, 2024
@geospatialem geospatialem added this to the Stalled milestone Apr 29, 2024
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Apr 29, 2024
@geospatialem
Copy link
Member

This may be resolved by the effort of #8490 and #9145, targeted for the May release. Blocking the above to determine if the above is mitigated as a result

@geospatialem
Copy link
Member

geospatialem commented May 3, 2024

The above was not mitigated with the fix mentioned above in 2.8.1-next.2, removing the block label for future triage.

@geospatialem geospatialem added needs triage Planning workflow - pending design/dev review. p - medium Issue is non core or affecting less that 60% of people using the library and removed blocked This issue is blocked by another issue. labels May 3, 2024
@geospatialem geospatialem removed this from the Stalled milestone May 3, 2024
@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 28, 2024
@geospatialem
Copy link
Member

spike to verify the approach above in comparison to the epic for truncation from #6661

@DitwanP DitwanP added spike complete Issues that have a research spike completed and dev work can proceed and removed spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. labels Jun 3, 2024
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 3, 2024
Copy link
Contributor

github-actions bot commented Jun 3, 2024

cc @geospatialem, @brittneytewks

@DitwanP DitwanP added 1 - assigned Issues that are assigned to a sprint and a team member. estimate - 2 Small fix or update, may require updates to tests. and removed 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 3, 2024
Copy link
Contributor

github-actions bot commented Jul 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jul 7, 2024
Copy link
Contributor

This issue has been automatically closed due to inactivity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2024
@DitwanP DitwanP reopened this Jul 17, 2024
@DitwanP DitwanP removed the Stale Issues or pull requests that have not had recent activity. label Jul 17, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Aug 17, 2024
Copy link
Contributor

This issue has been automatically closed due to inactivity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2024
@DitwanP DitwanP reopened this Aug 28, 2024
@DitwanP DitwanP removed the Stale Issues or pull requests that have not had recent activity. label Aug 28, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

This issue has been automatically closed due to inactivity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 9, 2024
@geospatialem geospatialem reopened this Dec 17, 2024
@geospatialem geospatialem added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed Stale Issues or pull requests that have not had recent activity. labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ArcGIS Mission Issues logged by ArcGIS Mission team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - medium Issue is non core or affecting less that 60% of people using the library spike complete Issues that have a research spike completed and dev work can proceed
Projects
None yet
Development

No branches or pull requests

3 participants