Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(tile): deprecate embed property #8833

Merged
merged 2 commits into from
Feb 27, 2024
Merged

docs(tile): deprecate embed property #8833

merged 2 commits into from
Feb 27, 2024

Conversation

eriklharper
Copy link
Contributor

Related Issues: #6662 #8351

Summary

Tile Select no longer uses Tile, and thus its internal embed property, so this PR marks it as deprecated.

@eriklharper eriklharper requested a review from a team as a code owner February 26, 2024 23:45
@github-actions github-actions bot added the docs Issues relating to documentation updates only. label Feb 26, 2024
@eriklharper eriklharper requested a review from jcfranco February 26, 2024 23:46
@eriklharper eriklharper added skip visual snapshots Pull requests that do not need visual regression testing. low risk Issues with low risk for consideration in low risk milestones labels Feb 26, 2024
driskull
driskull requested changes Feb 27, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing some doc 📝

packages/calcite-components/src/components/tile/tile.tsx Outdated Show resolved Hide resolved
driskull
driskull approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eriklharper eriklharper mentioned this pull request Feb 27, 2024
Closed
38 tasks
@eriklharper eriklharper merged commit f7e885a into main Feb 27, 2024
11 checks passed
@eriklharper eriklharper deleted the eriklharper/tile-deprecate-embed branch February 27, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

@jcfranco jcfranco Awaiting requested review from jcfranco

@geospatialem geospatialem Awaiting requested review from geospatialem

Assignees

@eriklharper eriklharper

Labels
docs Issues relating to documentation updates only. low risk Issues with low risk for consideration in low risk milestones skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-02-27 - Feb Maintenance Release
Development

Successfully merging this pull request may close these issues.
2 participants
@eriklharper @driskull