Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tile Select: Remove dependency on Tile component #8351

Closed
1 of 5 tasks
eriklharper opened this issue Dec 6, 2023 · 2 comments
Closed
1 of 5 tasks

Tile Select: Remove dependency on Tile component #8351

eriklharper opened this issue Dec 6, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. c-tile Issues that pertain to the calcite-tile and related components estimate - 2 Small fix or update, may require updates to tests. refactor Issues tied to code that needs to be significantly reworked.
Milestone
2023 December Pri...

Comments

@eriklharper
Copy link
Contributor

Description

Move all UI and logic provided by calcite-tile into calcite-tile-select, without affecting any functionality of either component.

Proposed Advantages

Removing calcite-tile-select's dependency on calcite-tile will allow work to proceed on the new Tile redesign epic without breaking changes. After this task is complete, redesign work on calcite-tile can proceed unhindered by any need to wait for a breaking change release since calcite-tile-select will continue to work independently.

Which Component

calcite-tile-select

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@eriklharper eriklharper added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 6, 2023
@eriklharper eriklharper self-assigned this Dec 6, 2023
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Dec 6, 2023
@eriklharper eriklharper added 2 - in development Issues that are actively being worked on. estimate - 3 A day or two of work, likely requires updates to tests. c-tile Issues that pertain to the calcite-tile and related components estimate - 2 Small fix or update, may require updates to tests. and removed 0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. needs triage Planning workflow - pending design/dev review. estimate - 3 A day or two of work, likely requires updates to tests. labels Dec 6, 2023
This was referenced Dec 7, 2023
Merged
Closed
eriklharper added a commit that referenced this issue Dec 9, 2023
@eriklharper
refactor(tile-select): remove dependency on calcite-tile (#8360)
088487d 
**Related Issue:** #8351 

## Summary

This PR removes `calcite-tile` as a dependency of `calcite-tile-select`.
All of `calcite-tile`'s HTML and CSS is now used directly inside
`calcite-tile-select`. This is the first part of the Tile redesign epic
and will allow for us to proceed with implementing the new components
without affecting the existing `calcite-tile-select-group` /
`calcite-tile-select` usage.

---------

Co-authored-by: Erik Harper <[email protected]>
@eriklharper eriklharper added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 13, 2023
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned DitwanP and unassigned eriklharper Dec 13, 2023
@DitwanP
Copy link
Contributor

DitwanP commented Dec 14, 2023

🍭 Verified locally on main

@DitwanP DitwanP closed this as completed Dec 14, 2023
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 14, 2023
@geospatialem geospatialem added this to the 2023 December Priorities milestone Dec 19, 2023
@eriklharper eriklharper mentioned this issue Feb 26, 2024
Merged
eriklharper added a commit that referenced this issue Feb 27, 2024
@eriklharper
docs(tile): deprecate embed property (#8833)
f7e885a 
**Related Issues:** #6662 #8351

## Summary

Tile Select no longer uses Tile, and thus its internal `embed` property,
so this PR marks it as deprecated.

---------

Co-authored-by: Erik Harper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. c-tile Issues that pertain to the calcite-tile and related components estimate - 2 Small fix or update, may require updates to tests. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2023 December Priorities
Development

No branches or pull requests
3 participants
@eriklharper @geospatialem @DitwanP