Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(changelog): fix synced version group name #8762

Merged

Conversation

jcfranco
Copy link
Member

Related Issue: N/A

Summary

This updates the release-please config to use groupName vs group-name to fix synced version changelog entries (notice undefined below):

2.2.0 (2024-01-17)

Miscellaneous Chores

  • @esri/calcite-components-react: Synchronize undefined versions

@jcfranco jcfranco requested a review from benelan February 15, 2024 22:32
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Feb 15, 2024
@jcfranco jcfranco marked this pull request as ready for review February 15, 2024 22:38
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I verified that it is groupName by searching in the release please config's JSON schema

@jcfranco jcfranco added low risk Issues with low risk for consideration in low risk milestones skip visual snapshots Pull requests that do not need visual regression testing. labels Feb 15, 2024
@jcfranco jcfranco merged commit 6dcf525 into main Feb 15, 2024
14 of 15 checks passed
@jcfranco jcfranco deleted the jcfranco/fix-release-please-synced-version-group-name branch February 15, 2024 22:53
benelan added a commit that referenced this pull request Feb 15, 2024
* origin/main: (22 commits)
  fix: ensure ui-icons are copied from correct path (#8761)
  build(changelog): fix synced version group name (#8762)
  chore: release main (#8706)
  fix(stepper): no longer adds default `min-width` for items when `layout='horizontal'` (#8758)
  build(deps): update dependency @floating-ui/dom to v1.6.3 (#8759)
  chore: release next
  feat(table): Improve accessibility of interaction-mode: static Table (#8754)
  chore: release next
  fix: fix dragging items on a mobile device (#8751)
  build(deps): update dependency @esri/calcite-ui-icons to v3.26.4 (#8752)
  chore: release next
  fix: prevent interaction when component is disabled after initialization (Firefox) (#8746)
  fix: fix styling when dragging items on a mobile device (#8750)
  chore: release next
  feat(stepper): add horizontal-single layout (#8742)
  revert: fix(panel, flow-item): remove overflow rule (#8711)
  refactor(input): tidy up input spec test (#8733)
  chore: improve doc for createBreakpointStories helper (#8739)
  chore: release next
  feat(table): Add `interactionMode` property to control focus behavior (#8686)
  ...
benelan added a commit that referenced this pull request Feb 15, 2024
**Related Issue:** #8763

## Summary

#8762 fixed the synced version group name in the latest release-please
pull request. This updates the group name in the changelogs for previous
versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. low risk Issues with low risk for consideration in low risk milestones skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants