fix: fix dragging items on a mobile device #8751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
…ign-system into dris0000/sortable-patch
# Conflicts: # package-lock.json
driskull
requested review from
benelan,
jcfranco,
geospatialem and
a team
as code owners
jcfranco
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹
🩹📦📦📦📦🩹📦🩹🩹🩹🩹🩹📦🩹📦📦📦📦🩹🩹📦📦📦🩹🩹📦📦🩹🩹📦🩹🩹🩹📦🩹📦📦📦📦🩹📦🩹
🩹📦🩹🩹📦🩹📦🩹🩹🩹🩹🩹📦🩹📦🩹🩹🩹🩹📦🩹🩹🩹🩹📦🩹🩹📦🩹📦📦🩹📦📦🩹📦🩹🩹🩹🩹📦🩹
🩹📦📦📦📦🩹📦🩹🩹📦🩹🩹📦🩹📦📦📦🩹🩹🩹📦📦🩹🩹📦🩹🩹📦🩹📦🩹📦🩹📦🩹📦📦📦🩹🩹📦🩹
🩹📦🩹🩹📦🩹📦🩹📦🩹📦🩹📦🩹📦🩹🩹🩹🩹🩹🩹🩹📦🩹📦🩹🩹📦🩹📦🩹🩹🩹📦🩹📦🩹🩹🩹🩹🩹🩹
🩹📦🩹🩹📦🩹🩹📦🩹🩹🩹📦🩹🩹📦📦📦📦🩹📦📦📦🩹🩹🩹📦📦🩹🩹📦🩹🩹🩹📦🩹📦📦📦📦🩹📦🩹
🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹🩹
Before merging, could you update the PR title similar to #8750 and create a follow-up issue for me to add guidelines for local package patching?
Thanks for fixing this!
driskull
changed the title
driskull
changed the title
|
created #8755 |
driskull
added
low risk
Merged
Elijbet
pushed a commit
that referenced
this pull request
Feb 15, 2024
**Related Issue:** #8728 ## Summary - Fixes dragging when on a mobile device. - Sortablejs uses fallback code instead of native drag and drop on mobile devices. - Patches `sortablejs` dependency until the fix for the issue is installed and released. SortableJS/Sortable#2346 - Adds and uses the dependency `patch-package` to handle patching the dependency. - Applies the changes listed here: SortableJS/Sortable#2347 --------- Co-authored-by: JC Franco <[email protected]>
jcfranco
pushed a commit
that referenced
this pull request
Feb 15, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.5.0</summary> ## [2.5.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-02-15) ### Features * **stepper:** Add horizontal-single layout ([#8742](#8742)) ([c34bc4f](c34bc4f)) * **table:** Add `interactionMode` property to control focus behavior ([#8686](#8686)) ([0cb78c0](0cb78c0)) * **table:** Improve accessibility of interaction-mode: static Table ([#8754](#8754)) ([eead1b5](eead1b5)) * **tile:** Add responsive layout features ([#8691](#8691)) ([f4f872e](f4f872e)) ### Bug Fixes * **color-picker:** Alpha-channel slider scope updates to reflect current opacity ([#8700](#8700)) ([cd0b532](cd0b532)) * **combobox:** Avoid inline-start padding on combobox label when icon is displayed ([#8672](#8672)) ([9eb680a](9eb680a)) * Don't override existing validationMessage when displaying after form submission ([#8690](#8690)) ([3076220](3076220)) * Fix dragging items on a mobile device ([#8751](#8751)) ([dc11612](dc11612)) * Fix styling when dragging items on a mobile device ([#8750](#8750)) ([7c01e6e](7c01e6e)) * **input, input-number, input-text, text-area:** Ensure all applicable props are considered in form validation ([#8655](#8655)) ([6de8534](6de8534)) * **list-item:** Fix slotted list border styling. ([#8712](#8712)) ([855f98d](855f98d)) * **loader:** Optimize animation performance ([#8714](#8714)) ([1ed8a01](1ed8a01)) * **preset:** Add back legacy token for calcite-ui-focus-color ([#8694](#8694)) ([1d1b933](1d1b933)) * Prevent interaction when component is disabled after initialization (Firefox) ([#8746](#8746)) ([aa84182](aa84182)) * **stepper:** No longer adds default `min-width` for items when `layout='horizontal'` ([#8758](#8758)) ([23a7439](23a7439)) ### Reverts * Fix(panel, flow-item): remove overflow rule ([#8711](#8711)) ([21226ce](21226ce)) </details> <details><summary>@esri/calcite-components-angular: 2.5.0</summary> ## [2.5.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-02-15) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.5.0-next.6 to ^2.5.0 </details> <details><summary>@esri/calcite-components-react: 2.5.0</summary> ## [2.5.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-02-15) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.5.0-next.6 to ^2.5.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
benelan
added a commit
that referenced
this pull request
Feb 15, 2024
* origin/main: (22 commits) fix: ensure ui-icons are copied from correct path (#8761) build(changelog): fix synced version group name (#8762) chore: release main (#8706) fix(stepper): no longer adds default `min-width` for items when `layout='horizontal'` (#8758) build(deps): update dependency @floating-ui/dom to v1.6.3 (#8759) chore: release next feat(table): Improve accessibility of interaction-mode: static Table (#8754) chore: release next fix: fix dragging items on a mobile device (#8751) build(deps): update dependency @esri/calcite-ui-icons to v3.26.4 (#8752) chore: release next fix: prevent interaction when component is disabled after initialization (Firefox) (#8746) fix: fix styling when dragging items on a mobile device (#8750) chore: release next feat(stepper): add horizontal-single layout (#8742) revert: fix(panel, flow-item): remove overflow rule (#8711) refactor(input): tidy up input spec test (#8733) chore: improve doc for createBreakpointStories helper (#8739) chore: release next feat(table): Add `interactionMode` property to control focus behavior (#8686) ...
jcfranco
added a commit
that referenced
this pull request
Feb 16, 2024
**Related Issue:** N/A ## Summary Cleans up package-patching scripts (introduced in #8751) to prevent them from running on `calcite-components` installs.
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #8728
Summary
sortablejsdependency until the fix for the issue is installed and released. [bug] Sortable swapping does not work when forceFallback is enabled and a handle or content is a custom element (web component) with a shadowRoot SortableJS/Sortable#2346patch-packageto handle patching the dependency.