fix(combobox): fix issue causing value to be cleared when selecting an item (Windows + trackpad) #7954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n item (Windows + trackpad)
github-actions
bot
added
the
bug
jcfranco
added
p - critical
jcfranco
deleted the
jcfranco/7934-fix-deselecting-of-value-when-selecting-item
branch
|
@anveshmekala Could you give this a look and comment if you notice anything I may have missed? |
Merged
This will break the issue #2162 when the user chooses to enter some custom value and tab out of the component. The tests should have cover this scenario but they are validating against the value property which will be empty since there are no |
geospatialem
pushed a commit
that referenced
this pull request
Oct 6, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 1.9.1</summary> ## [1.9.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2023-10-05) ### Bug Fixes * **combobox:** Fix issue causing value to be cleared when selecting an item (Windows + trackpad) ([#7954](#7954)) ([557d658](557d658)) * **input-time-zone:** Fix handling of unknown and cityless time zones from offset display mode ([#7947](#7947)) ([75e0302](75e0302)) * **panel:** Fix collapse action title and reverse icon direction ([#7927](#7927)) ([5f620f8](5f620f8)) </details> <details><summary>@esri/calcite-components-react: 1.9.1</summary> ## [1.9.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2023-10-05) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^1.9.1-next.1 to ^1.9.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
Yikes, thanks for catching that! I knew this fix felt too easy. 😂 |
jcfranco
added
regression
benelan
added a commit
that referenced
this pull request
Oct 11, 2023
* origin/main: (83 commits) chore: add design tokens to monorepo (#7948) test(input-time-zone): restore common tests (#7963) chore: release next fix(input-time-zone): fix error caused by time zone group filtering (#7971) chore: release next fix(table): Improve scrollbar display (#7967) build: bump timezone-groups (#7962) chore: release next fix(flow-item): update collapsed property when collapse button is clicked (#7960) chore: release main (#7945) chore: release next fix(input-time-zone): fix handling of unknown and cityless time zones from offset display mode (#7947) fix(combobox): fix issue causing value to be cleared when selecting an item (Windows + trackpad) (#7954) chore(deps): update calcite-ui-icons to 3.24.7 (#7949) test(flow-item, panel): add tests for internal property. (#7931) chore: release next fix(panel): fix collapse action title and reverse icon direction (#7927) chore: update issue template labels to support workflows (#7938) build(deps): bump timezone-groups (#7933) build(deps): update dependency @esri/calcite-ui-icons to v3.24.6 (#7925) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7934
Summary
Updates the component to consistently bail on blur handling logic if the input is blurred, but focus is still within the component.
Notes