Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combobox - filtering combobox items and selecting by tap fails to update the selected item #7934

Closed
2 of 4 tasks
ian13262 opened this issue Oct 4, 2023 · 3 comments
Closed
2 of 4 tasks

Combobox - filtering combobox items and selecting by tap fails to update the selected item #7934

ian13262 opened this issue Oct 4, 2023 · 3 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Milestone
1.9.1 Maintenance...

Comments

@ian13262
Copy link

ian13262 commented Oct 4, 2023 •
edited by geospatialem
Loading

Check existing issues

Actual Behavior

Here is a very specific workflow in 1.9 only that does not follow expected combobox behavior:

1.) Click to open a combobox with multiple selected items
2.) Filter the items by typing some input
3.) Choose a filtered item, but carefully! This item must be:

  • Not in its original position in the list
  • Selected by tapping a trackpad (and occasionally by clicking with a mouse, but this is variable)

4.) The new item will not be selected appropriately.

Expected Behavior

The workflow above should correctly select that tapped item, but it doesn't.

Reproduction Sample

https://codepen.io/iyouth66/pen/LYMgEOW

Reproduction Steps

See above.

Demo:
https://github.com/Esri/calcite-design-system/assets/131201379/4367da0a-936d-44e5-b685-8349a3df30fc

Reproduction Version

1.9

Relevant Info

Windows 10 (must use trackpad tap to reliably reproduce this issue); Chrome Version 117.0.5938.150 (Official Build) (64-bit)

Note: Also seems to apply to the Mac OS trackpad.

cc @geospatialem - hoping to have this for 1.9.1, if time permits.

Regression?

1.8

Priority impact

p1 - need for current milestone

Impact

All comboboxes are affected, particularly single-persist ones (time-zone component, field selection, etc.).

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online
@ian13262 ian13262 added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Oct 4, 2023
@github-actions github-actions bot added impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Online Issues logged by ArcGIS Online team members. labels Oct 4, 2023
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that. labels Oct 4, 2023
@geospatialem
Copy link
Member

Possibly related to #7721. The above sample works as-expected in 1.8.0-next.0, but shows starting at 1.8.0-next.1.

@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Oct 5, 2023
@jcfranco jcfranco self-assigned this Oct 5, 2023
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Oct 5, 2023
@jcfranco jcfranco mentioned this issue Oct 5, 2023
Merged
jcfranco added a commit that referenced this issue Oct 5, 2023
@jcfranco
fix(combobox): fix issue causing value to be cleared when selecting a…
557d658 
…n item (Windows + trackpad) (#7954)

**Related Issue:** #7934 

## Summary

Updates the component to consistently bail on blur handling logic if the
input is blurred, but focus is still within the component.

### Notes

* the regression was introduced by
#7721
* due to time constraints, testing will be tackled in a follow-up issue
as it's not easy to reproduce in an E2E test.
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 5, 2023
@github-actions github-actions bot assigned geospatialem and unassigned jcfranco Oct 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 5, 2023
@geospatialem
Copy link
Member

Verified in 1.9.1-next.1 with Windows trackpad in Chrome Version 117.0.5938.149 (Official Build) (64-bit)

This was referenced Oct 23, 2023
Closed
Merged
jcfranco added a commit that referenced this issue Oct 24, 2023
@jcfranco
test(combobox): add test for filter being cleared if there's a delay …
6fff2f9 
…between pointer down and up (#8045)

**Related Issue:** #7955 

## Summary

Adds missing test from #7934.
@geospatialem geospatialem mentioned this issue Oct 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
1.9.1 Maintenance Release
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @ian13262