fix(combobox): prevents navigation list with Space key #7505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
anveshmekala
added
the
pr ready for visual snapshots
driskull
approved these changes
Aug 10, 2023
packages/calcite-components/src/components/combobox/combobox.tsx
Outdated
Show resolved
Hide resolved
anveshmekala
added
pr ready for visual snapshots
anveshmekala
deleted the
anveshmekala/6387-combobox-prevent-spacekey-navigating-list
branch
Merged
anveshmekala
added
the
low risk
benelan
pushed a commit
that referenced
this pull request
Aug 15, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 1.6.0</summary> ## [1.6.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2023-08-15) ### Features * **action-bar:** Add "actions-end" slot (deprecates "bottom-actions") ([#7435](#7435)) ([1bf14ff](1bf14ff)) ### Bug Fixes * **block:** Defaults the status icon to `scale=s` ([#7503](#7503)) ([e1aee99](e1aee99)) * **button,card,fab,inline-editable:** Provides context to AT users when loading ([#7257](#7257)) ([df33eda](df33eda)) * **chip-group:** Add existence checks ([#7487](#7487)) ([33225a7](33225a7)) * **combobox:** Prevents navigation list with Space key ([#7505](#7505)) ([58e2ff2](58e2ff2)) * **panel:** Fix heading border when only text content is slotted ([#7491](#7491)) ([7704400](7704400)) * **progress:** Completes animation for `dir='rtl'` ([#7511](#7511)) ([c5d6ada](c5d6ada)) * **scrim:** Handle slotted children correctly ([#7477](#7477)) ([c5ce008](c5ce008)) * **scrim:** Render text content inside scrim ([#7509](#7509)) ([643ce5d](643ce5d)) * **slider:** Rerender ticks when prop is modified ([#7439](#7439)) ([20058a9](20058a9)) * **tree:** Selects all child items when selection-mode is set to ancestors ([#7518](#7518)) ([f1eef84](f1eef84)) </details> <details><summary>@esri/calcite-components-react: 1.6.0</summary> ## [1.6.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2023-08-15) ### Bug Fixes * Prevent vitetest/ssr errors due to defining components on the server ([#7521](#7521)) ([046672e](046672e)) ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^1.6.0-next.7 to ^1.6.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
benelan
pushed a commit
that referenced
this pull request
Aug 16, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 1.6.0</summary> ## [1.6.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2023-08-15) ### Features * **action-bar:** Add "actions-end" slot (deprecates "bottom-actions") ([#7435](#7435)) ([1bf14ff](1bf14ff)) ### Bug Fixes * **block:** Defaults the status icon to `scale=s` ([#7503](#7503)) ([e1aee99](e1aee99)) * **button,card,fab,inline-editable:** Provides context to AT users when loading ([#7257](#7257)) ([df33eda](df33eda)) * **chip-group:** Add existence checks ([#7487](#7487)) ([33225a7](33225a7)) * **combobox:** Prevents navigation list with Space key ([#7505](#7505)) ([58e2ff2](58e2ff2)) * **panel:** Fix heading border when only text content is slotted ([#7491](#7491)) ([7704400](7704400)) * **progress:** Completes animation for `dir='rtl'` ([#7511](#7511)) ([c5d6ada](c5d6ada)) * **scrim:** Handle slotted children correctly ([#7477](#7477)) ([c5ce008](c5ce008)) * **scrim:** Render text content inside scrim ([#7509](#7509)) ([643ce5d](643ce5d)) * **slider:** Rerender ticks when prop is modified ([#7439](#7439)) ([20058a9](20058a9)) * **tree:** Selects all child items when selection-mode is set to ancestors ([#7518](#7518)) ([f1eef84](f1eef84)) </details> <details><summary>@esri/calcite-components-react: 1.6.0</summary> ## [1.6.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2023-08-15) ### Bug Fixes * Prevent vitetest/ssr errors due to defining components on the server ([#7521](#7521)) ([046672e](046672e)) ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^1.6.0-next.7 to ^1.6.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6387
Summary
This prevents
Spacekey navigating combobox list when opened.