Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Combobox] Using space key while focusing on a Combobox Item advances selection #6387

Closed
macandcheese opened this issue Jan 31, 2023 · 4 comments
Closed

[Combobox] Using space key while focusing on a Combobox Item advances selection #6387

macandcheese opened this issue Jan 31, 2023 · 4 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-combobox Issues that pertain to the calcite-combobox and related components Calcite (design) Issues logged by Calcite designers. estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library
Milestone
1.6.0 - Low risk ...

Comments

@macandcheese
Copy link
Contributor

Actual Behavior

Using the space key while focus is on a Combobox Item ("combobox open") advances focus to the next item.

Expected Behavior

I might expect space to behave like enter - cc @geospatialem for a11y opinion.

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/combobox/

Reproduction Steps

  1. View sample link
  2. Open the combobox
  3. Use the space key
  4. See that the focused item "advances" to the next one without selection.

Reproduction Version

1.0.3

Relevant Info

No response

Regression?

Functioned this way as far back as beta.86, at least.

Impact

Unsure, but struck me as unexpected.

Esri team

Calcite (design)
@macandcheese macandcheese added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 31, 2023
@github-actions github-actions bot added the Calcite (design) Issues logged by Calcite designers. label Jan 31, 2023
@geospatialem
Copy link
Member

I might expect space to behave like enter

Would concur, per the W3C combobox where spacebar and Enter keys perform the same action on its items.

Also, of note also applies to the tab key, but that might be out of scope for this issue.

@macandcheese macandcheese added the c-combobox Issues that pertain to the calcite-combobox and related components label Mar 22, 2023
@brittneytewks brittneytewks added p - low Issue is non core or affecting less that 10% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. labels Apr 11, 2023
@brittneytewks brittneytewks added this to the 2023 August Priorities milestone Apr 11, 2023
@brittneytewks brittneytewks removed the needs triage Planning workflow - pending design/dev review. label Apr 11, 2023
@geospatialem
Copy link
Member

geospatialem commented Apr 11, 2023 •
edited
Loading

Not currently a pattern in combobox, but agree it is odd behavior: https://www.w3.org/WAI/ARIA/apg/patterns/combobox/.

The solution should use the prevent default so the next item isn't selected.

@anveshmekala anveshmekala self-assigned this Aug 10, 2023
@anveshmekala anveshmekala added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Aug 10, 2023
@anveshmekala anveshmekala mentioned this issue Aug 10, 2023
Merged
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 10, 2023
anveshmekala added a commit that referenced this issue Aug 11, 2023
@anveshmekala
fix(combobox): prevents navigation list with Space key (#7505)
58e2ff2 
**Related Issue:** #6387 

## Summary

This prevents `Space` key navigating combobox list when opened.
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 11, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem removed this from the 2023 August Priorities milestone Aug 13, 2023
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 13, 2023
@geospatialem
Copy link
Member

Verified in 1.6.0-next.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-combobox Issues that pertain to the calcite-combobox and related components Calcite (design) Issues logged by Calcite designers. estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
1.6.0 - Low risk issues only
Development

No branches or pull requests
5 participants
@alisonailea @macandcheese @geospatialem @anveshmekala @brittneytewks