Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(shell-panel): Remove usage of getSlotted utility. #6059 #7465

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

driskull
Copy link
Member

@driskull driskull commented Aug 4, 2023

Related Issue: #6059

Summary

  • Remove usage of getSlotted utility

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Aug 4, 2023
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Aug 4, 2023
@driskull driskull marked this pull request as ready for review August 7, 2023 22:52
@driskull driskull requested a review from a team as a code owner August 7, 2023 22:52
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Aug 15, 2023
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this covered by an existing test? If so, this LGTM!

This looks low-risk to me.

@driskull driskull merged commit 152fc7d into main Aug 15, 2023
@driskull driskull deleted the dris0000/shell-panel-getSlotted-refactor branch August 15, 2023 20:13
@github-actions github-actions bot added this to the 2023 August Priorities milestone Aug 15, 2023
benelan pushed a commit that referenced this pull request Aug 16, 2023
**Related Issue:** #6059

## Summary

- Remove usage of getSlotted utility
benelan added a commit that referenced this pull request Aug 17, 2023
* origin/main:
  chore: release next
  chore: add `directory` to package.json `repository` property (#7510)
  fix(action-bar): restore "bottom-actions" slot functionality. (#7535)
  refactor(action-bar, action-pad, action-group): Remove usage of getSlotted utility (#7464)
  build(deps): update dependency lerna to v7.1.5 (#7502)
  build(deps): update dependency @esri/calcite-ui-icons to v3.23.7 (#7522)
  refactor(shell-panel): Remove usage of getSlotted utility. #6059 (#7465)
  build(deps): update dependency eslint-plugin-unicorn to v46.0.1 (#7501)
  build(deps): replace dependency rollup-plugin-node-resolve with @rollup/plugin-node-resolve 6.0.0 (#7481)
  test: skip unstable tests (#7524)
  build(deps): update dependency lint-staged to v13.2.3 (#7523)
  build(deps): update dependency @types/estree to v1.0.1 (#7483)
  build(deps): update dependency eslint-plugin-react to v7.33.1 (#7500)
  build(deps): update dependency eslint-plugin-jsdoc to v46.4.6 (#7499)
  build(deps): update dependency @types/node to v20.4.10 (#7484)
  chore: release next
  chore: release main (#7485)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants