-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(action-bar, action-pad, action-group): Remove usage of getSlotted utility #7464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions-end" slot .
driskull
changed the title
refactor(action-bar, action-pad, action-group): Remove use of getSlotted utility. #6059
refactor(action-bar, action-pad, action-group): Remove use of getSlotted utility
Aug 4, 2023
driskull
changed the title
refactor(action-bar, action-pad, action-group): Remove use of getSlotted utility
refactor(action-bar, action-pad, action-group): Remove usage of getSlotted utility
Aug 5, 2023
driskull
added
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
and removed
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
labels
Aug 5, 2023
# Conflicts: # packages/calcite-components/src/components/action-bar/action-bar.tsx # packages/calcite-components/src/components/action-pad/action-pad.tsx
github-actions
bot
added
the
refactor
Issues tied to code that needs to be significantly reworked.
label
Aug 8, 2023
driskull
added
the
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
label
Aug 8, 2023
jcfranco
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM and also looks low-risk.
packages/calcite-components/src/components/action-bar/action-bar.e2e.ts
Outdated
Show resolved
Hide resolved
driskull
added
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
and removed
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
labels
Aug 15, 2023
benelan
added a commit
that referenced
this pull request
Aug 17, 2023
* origin/main: chore: release next chore: add `directory` to package.json `repository` property (#7510) fix(action-bar): restore "bottom-actions" slot functionality. (#7535) refactor(action-bar, action-pad, action-group): Remove usage of getSlotted utility (#7464) build(deps): update dependency lerna to v7.1.5 (#7502) build(deps): update dependency @esri/calcite-ui-icons to v3.23.7 (#7522) refactor(shell-panel): Remove usage of getSlotted utility. #6059 (#7465) build(deps): update dependency eslint-plugin-unicorn to v46.0.1 (#7501) build(deps): replace dependency rollup-plugin-node-resolve with @rollup/plugin-node-resolve 6.0.0 (#7481) test: skip unstable tests (#7524) build(deps): update dependency lint-staged to v13.2.3 (#7523) build(deps): update dependency @types/estree to v1.0.1 (#7483) build(deps): update dependency eslint-plugin-react to v7.33.1 (#7500) build(deps): update dependency eslint-plugin-jsdoc to v46.4.6 (#7499) build(deps): update dependency @types/node to v20.4.10 (#7484) chore: release next chore: release main (#7485)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
refactor
Issues tied to code that needs to be significantly reworked.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6059
Summary