fix(slider): dragging range fires input event #5641

alisonailea · 2022-10-25T22:55:42Z

Related Issue: #5449

Summary

updates the private setValue method to accept (n) props to update on the component.
updated dragUpdate to call setValue with minValue & maxValue on drag.

alisonailea · 2022-10-26T18:05:02Z

src/components/slider/slider.tsx

@@ -824,7 +825,9 @@ export class Slider
    }
    event.preventDefault();
    const fixedDecimalAdjustment = Number(adjustment.toFixed(decimalPlaces(step)));
-    this.setValue(activeProp, this.clamp(fixedDecimalAdjustment, activeProp));
+    this.setValue({
+      [activeProp as SetValueProperty]: this.clamp(fixedDecimalAdjustment, activeProp)


driskull

Looks good! ✨

(☞ﾟヮﾟ)☞ ❤️

* feat(button): add built-in translations * change watcher order * remove intl default test assertion * cleanup * handle edge case * fix build errors * docs(conventions): update style guide (#5530) * fix(slider): fix slider (single-value) error when clicking range (#5533) #5321 * 1.0.0-next.603 * ci(screener): reenable screener on pushes to master to update baseline (#5528) * ci(screener): renable screener on pushes to master to update baseline * cleanup Co-authored-by: Ben Elan <[email protected]> * fix: components should only react to primary button pointer events. (#5519) * fix: components should only react to primary pointer events. * cleanup. add pointerdown * fix test * make sure primary? * review fixes * 1.0.0-next.604 * feat(date-picker, input-date-picker): add numberingSystem property (#5488) * feat(date-picker): add numberingSystem property * docs(date-picker): cleanup lang/numberingSystem selection code * feat(input-date-picker): add numberingSystem property [WIP] * add stories * cleanup * fix spec test * cleanup * test(date-picker-day): fix failing disabled commonTest * merge master * cleanup * review cleanups * skip (de)localization when formatter is not initialized * cleanup and add a spec test * don't init formatter until necessary * final cleanup * replace stepped stories and change locale to lang * test(input-date-picker): add dark theme class to darkThemeRTL story Co-authored-by: Ben Elan <[email protected]> * 1.0.0-next.605 * docs: consistent api styling + define card thumbnailPosition (#5518) * docs(card): defined thumbnailPosition and consistent api styling across component * fix typo * remove extraneous dash * add backticks to comps * add b + c component consistency * edits * doc feedback * fix(value-list-item): Change drag handle color. (#5543) * 1.0.0-next.606 * fix: add custom logic for floating-ui positioning across shadow DOM in non-Chromium browsers (#5542) * fix: add custom code for floating-ui positioning across shadow DOM in non-Chrome browsers * tidy up * fix conditional to avoid setting up fix for non-browser environments * provide a way to opt-out of fix in favor of performance * fix: fix jarring positioning when a closed component is first opened (#5484) * fix: fix jarring positioning when a closed component is first opened * uncomment actual fix and switch story to be stepped * tweak story to capture initial positioning * fix typo * add missing setAttr argument * add delay before screenshot test setup * revisit approach to preserve debounced internal repositioning calls and correct positioning * drop unnecessary story * tidy up * fix hydrate build * restore leading option * update test * tweak positioning * drop scale transformto have correct dimensions initially * reposition immediately on componentDidLoad * update tests * revert index.html updates * use transitions to reset positioning * fix test. Co-authored-by: Matt Driscoll <[email protected]> * 1.0.0-next.607 * fix(calcite-loader, calcite-input-message): drop active in favor of hidden (#5537) * fix(calcite-loader, calcite-input-message): drop active in favor of hidden * changes applied to input-message * modify render assertion in the tests * remove redundant hidden prop along with documentation (global attribute) * add the link to mdn hidden attribute * 1.0.0-next.608 * feat(flow-item): Add calciteFlowItemScroll event (#5547) * feat(flow-item): Add scroll event. (#5546) * add a test * 1.0.0-next.609 * ci: adds w3c url for a11y issue filing (#5556) ci: update need info url for a11y * fix(date-picker): display correct date format order in header for zh-CN locale. (#5534) fix(date-picker): display correct date format order in header for zh-CN locale * 1.0.0-next.610 * fix(stepper-item): make sure numberingSystem is rendered on load (#5640) * fix(stepper-item): set numberingSystem in render block * cleanup * cleanup the cleanup Co-authored-by: Ben Elan <[email protected]> * 1.0.0-next.611 * feedback changes * remove browser build conditional * fix(slider): dragging range fires input event (#5641) #5449 * fix(tooltip): Prevent opening when closeOnClick is true and referenceElement is clicked quickly (#5643) * fix(tooltip): Stop hover event when closeOnClick is true and click occurs. (#5538) * add test * review cleanup * fix(types): fix type issue caused by unintentionally moving @floating-ui/dom as a dev dependency (#5649) * avoid fetching in hydrate builds * resolve conflicts * clean up * more cleanup Co-authored-by: Ben Elan <[email protected]> Co-authored-by: JC Franco <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ben Elan <[email protected]> Co-authored-by: Matt Driscoll <[email protected]> Co-authored-by: Kitty Hurley <[email protected]> Co-authored-by: Eliza Khachatryan <[email protected]> Co-authored-by: Alison Stump <[email protected]>

fix(slider): onCalciteSliderInput fires onDrag

5eecfa6

alisonailea requested a review from a team as a code owner October 25, 2022 22:55

github-actions bot assigned alisonailea Oct 25, 2022

github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Oct 25, 2022

add test, fix types and tidy up

cb9a507

jcfranco changed the title ~~fix(slider): onCalciteSliderInput fires onDrag~~ fix(slider): dragging range fires input event Oct 26, 2022

jcfranco requested review from benelan and driskull October 26, 2022 17:54

alisonailea commented Oct 26, 2022

View reviewed changes

driskull approved these changes Oct 26, 2022

View reviewed changes

jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Oct 26, 2022

jcfranco merged commit dc48d00 into master Oct 26, 2022

jcfranco deleted the astump/5449-slider branch October 26, 2022 21:12

github-actions bot added this to the Sprint 2022/10/24 - 2022/11/04 milestone Oct 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(slider): dragging range fires input event #5641

fix(slider): dragging range fires input event #5641

alisonailea commented Oct 25, 2022 •

edited by jcfranco

Loading

alisonailea Oct 26, 2022

driskull left a comment

fix(slider): dragging range fires input event #5641

fix(slider): dragging range fires input event #5641

Conversation

alisonailea commented Oct 25, 2022 • edited by jcfranco Loading

Summary

alisonailea Oct 26, 2022

Choose a reason for hiding this comment

driskull left a comment

Choose a reason for hiding this comment

alisonailea commented Oct 25, 2022 •

edited by jcfranco

Loading