Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slider: onCalciteSliderInput is not fired when dragging range #5449

Closed
wju opened this issue Oct 11, 2022 · 4 comments
Closed

Slider: onCalciteSliderInput is not fired when dragging range #5449

wju opened this issue Oct 11, 2022 · 4 comments
Assignees
@geospatialem @benelan
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Milestone
Sprint 2022/10/24...

Comments

@wju
Copy link

wju commented Oct 11, 2022

Actual Behavior

Drag the highlighted rod to move both thumb handles at the same time towards right, onCalciteSliderInput is only fired at the very beginning, and not fired while dragging or when dragging is ended.

Screen Shot 2022-10-11 at 12 48 37 PM

Screen Shot 2022-10-11 at 12 45 00 PM

Expected Behavior

onCalciteSliderInput is expected while dragging and when dragging is ended. Per doc

Fires on all updates to the component. Note: Will be fired frequently during drag

A side note. onCalciteSliderChange is fired when dragging is ended and can be used to mitigate the issue.

Reproduction Sample

https://codepen.io/wju/pen/poVqREv

Reproduction Steps

  1. Open the code pen sample, open and clear console.
  2. Move the mouse to place the cursor on the slider track, between of the two circles, until you see the pointer changes to a horizontal double arrow.
  3. Hold down the mouse the start dragging,
    check console: calciteSliderInput event is fired in the console.
  4. Drag rightwards towards the middle or the end of the slider
    check console: calciteSliderInput event is not fired in the console.
  5. Release the mouse.
    check console: calciteSliderInput event is not fired in the console.

Reproduction Version

beta.95

Relevant Info

Reproduced on MacOS / Chrome, Windows / Chrome but probably not OS/Browser specific.

Regression?

No response

Esri team

N/A
@wju wju added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Oct 11, 2022
@geospatialem geospatialem changed the title onCalciteSliderInput is not fired when dragging two thumbs at the same time Slider: onCalciteSliderInput is not fired when dragging range Oct 18, 2022
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Oct 18, 2022
@AdelheidF
Copy link

tested with next.603 https://codepen.io/afreitag/pen/gOzVoLR

driskull added a commit that referenced this issue Oct 25, 2022
@driskull
fix(slider): Emit calciteSliderInput on range drag. (#5449)
ad92a8f
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Oct 25, 2022
@AdelheidF
Copy link

tested with next.610, but it doesn't seem to be fixed there

@jcfranco jcfranco mentioned this issue Oct 26, 2022
Merged
jcfranco pushed a commit that referenced this issue Oct 26, 2022
@alisonailea
fix(slider): dragging range fires input event (#5641)
dc48d00 
#5449
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 26, 2022
@github-actions github-actions bot assigned benelan and geospatialem and unassigned jcfranco and alisonailea Oct 26, 2022
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@AdelheidF
Copy link

works with next.612

@AdelheidF AdelheidF added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 26, 2022
anveshmekala added a commit that referenced this issue Oct 26, 2022
@anveshmekala @benelan
@jcfranco @github-actions @driskull @geospatialem @Elijbet @alisonailea
feat(button): add built-in translations (#5447)
7bc4c50 
* feat(button): add built-in translations

* change watcher order

* remove intl default test assertion

* cleanup

* handle edge case

* fix build errors

* docs(conventions): update style guide (#5530)

* fix(slider): fix slider (single-value) error when clicking range (#5533)

#5321

* 1.0.0-next.603

* ci(screener): reenable screener on pushes to master to update baseline (#5528)

* ci(screener): renable screener on pushes to master to update baseline

* cleanup

Co-authored-by: Ben Elan <[email protected]>

* fix: components should only react to primary button pointer events. (#5519)

* fix: components should only react to primary pointer events.

* cleanup. add pointerdown

* fix test

* make sure primary?

* review fixes

* 1.0.0-next.604

* feat(date-picker, input-date-picker): add numberingSystem property (#5488)

* feat(date-picker): add numberingSystem property

* docs(date-picker): cleanup lang/numberingSystem selection code

* feat(input-date-picker): add numberingSystem property [WIP]

* add stories

* cleanup

* fix spec test

* cleanup

* test(date-picker-day): fix failing disabled commonTest

* merge master

* cleanup

* review cleanups

* skip (de)localization when formatter is not initialized

* cleanup and add a spec test

* don't init formatter until necessary

* final cleanup

* replace stepped stories and change locale to lang

* test(input-date-picker): add dark theme class to darkThemeRTL story

Co-authored-by: Ben Elan <[email protected]>

* 1.0.0-next.605

* docs: consistent api styling + define card thumbnailPosition (#5518)

* docs(card): defined thumbnailPosition and consistent api styling across component

* fix typo

* remove extraneous dash

* add backticks to comps

* add b + c component consistency

* edits

* doc feedback

* fix(value-list-item): Change drag handle color. (#5543)

* 1.0.0-next.606

* fix: add custom logic for floating-ui positioning across shadow DOM in non-Chromium browsers (#5542)

* fix: add custom code for floating-ui positioning across shadow DOM in non-Chrome browsers

* tidy up

* fix conditional to avoid setting up fix for non-browser environments

* provide a way to opt-out of fix in favor of performance

* fix: fix jarring positioning when a closed component is first opened (#5484)

* fix: fix jarring positioning when a closed component is first opened

* uncomment actual fix and switch story to be stepped

* tweak story to capture initial positioning

* fix typo

* add missing setAttr argument

* add delay before screenshot test setup

* revisit approach to preserve debounced internal repositioning calls and correct positioning

* drop unnecessary story

* tidy up

* fix hydrate build

* restore leading option

* update test

* tweak positioning

* drop scale transformto have correct dimensions initially
* reposition immediately on componentDidLoad

* update tests

* revert index.html updates

* use transitions to reset positioning

* fix test.

Co-authored-by: Matt Driscoll <[email protected]>

* 1.0.0-next.607

* fix(calcite-loader, calcite-input-message): drop active in favor of hidden (#5537)

* fix(calcite-loader, calcite-input-message): drop active in favor of hidden

* changes applied to input-message

* modify render assertion in the tests

* remove redundant hidden prop along with documentation (global attribute)

* add the link to mdn hidden attribute

* 1.0.0-next.608

* feat(flow-item): Add calciteFlowItemScroll event (#5547)

* feat(flow-item): Add scroll event. (#5546)

* add a test

* 1.0.0-next.609

* ci: adds w3c url for a11y issue filing (#5556)

ci: update need info url for a11y

* fix(date-picker): display correct date format order in header for zh-CN locale. (#5534)

fix(date-picker): display correct date format order in header for zh-CN locale

* 1.0.0-next.610

* fix(stepper-item): make sure numberingSystem is rendered on load (#5640)

* fix(stepper-item): set numberingSystem in render block

* cleanup

* cleanup the cleanup

Co-authored-by: Ben Elan <[email protected]>

* 1.0.0-next.611

* feedback changes

* remove browser build conditional

* fix(slider): dragging range fires input event (#5641)

#5449

* fix(tooltip): Prevent opening when closeOnClick is true and referenceElement is clicked quickly (#5643)

* fix(tooltip): Stop hover event when closeOnClick is true and click occurs. (#5538)

* add test

* review cleanup

* fix(types): fix type issue caused by unintentionally moving @floating-ui/dom as a dev dependency (#5649)

* avoid fetching in hydrate builds

* resolve conflicts

* clean up

* more cleanup

Co-authored-by: Ben Elan <[email protected]>
Co-authored-by: JC Franco <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ben Elan <[email protected]>
Co-authored-by: Matt Driscoll <[email protected]>
Co-authored-by: Kitty Hurley <[email protected]>
Co-authored-by: Eliza Khachatryan <[email protected]>
Co-authored-by: Alison Stump <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@benelan benelan

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Milestone
Sprint 2022/10/24 - 2022/11/04
Development

No branches or pull requests
6 participants
@jcfranco @alisonailea @geospatialem @wju @benelan @AdelheidF