fix(combobox): ensure truncated text appears for longer strings when in fixed-width container #3342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
…rom-pr-3143-regression
…rom-pr-3143-regression
|
@macandcheese can you accept the Screener change on this one if it looks good to you? |
|
@caripizza I approved in Screener - it looks like it hasn't updated here yet. |
|
@benelan do you know if I need to close and reopen this pr to get the approved Screener change to come through? (Tried a hard refresh but the checks still show as failed) |
caripizza
deleted the
caripizza/hotfix-combobox-truncated-text-from-pr-3143-regression
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #3341
Summary
This pr makes sure that a longer-text string in a combobox is truncated again when it's inside a smaller fixed-width container.
Also adds a longer text string to its "Multiple" story for Screener checking moving forward, and adds the repro markup to the demo page html.