Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: [combobox] longer strings aren't truncated anymore when in fixed-width container #3341

Closed
1 of 2 tasks
caripizza opened this issue Oct 23, 2021 · 3 comments
Closed
1 of 2 tasks

Bug: [combobox] longer strings aren't truncated anymore when in fixed-width container #3341

caripizza opened this issue Oct 23, 2021 · 3 comments
Assignees
@benelan
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.
Milestone
Sprint 10/11 – 10/22

Comments

@caripizza
Copy link
Contributor

Actual Behavior

Starting at next.290, longer combobox strings are no longer truncated when the combobox is nested in a smaller fixed-width container:

image

Expected Behavior

Longer combobox strings should be truncated when the combobox is nested in a smaller fixed-width container. The ellipsis should appear when the combobox has selection-mode "multi" or "ancestors" as well.

next.289:
image

Reproduction Steps and Sample

https://codepen.io/caripizza-the-animator/pen/qBXRBpd

Sample:

  1. Open the CodePen
  2. notice the combobox item text isn't truncated

Relevant Info

We added the ellipsis effect back in #2096.

It looks to me like maybe a regression from the chevron icon we added in pr #3143.

AFAIK, the ellipsis should appear in multi/ancestors selection-modes - single I think we removed the ellipsis from appearing in #3059.

Reproducible version: @esri/[email protected]

  • CDN
  • NPM package

Regression? Last working version: @esri/[email protected]
@caripizza caripizza added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Oct 23, 2021
@caripizza
Copy link
Contributor Author

(Self-assigning this per Teams conversation with @macandcheese)

@caripizza caripizza self-assigned this Oct 23, 2021
@caripizza caripizza added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Oct 23, 2021
@caripizza caripizza added this to the Sprint 10/11 – 10/22 milestone Oct 23, 2021
@caripizza caripizza mentioned this issue Oct 23, 2021
Merged
@caripizza caripizza added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 26, 2021
@github-actions github-actions bot assigned benelan and unassigned caripizza Oct 26, 2021
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@caripizza caripizza assigned benelan and unassigned benelan Oct 26, 2021
@benelan
Copy link
Member

benelan commented Nov 1, 2021

verified on beta.68 in repro sample

@benelan benelan closed this as completed Nov 1, 2021
@benelan benelan added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benelan benelan

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Milestone
Sprint 10/11 – 10/22
Development

No branches or pull requests
2 participants
@benelan @caripizza