Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog): no longer apply transform styling unless dragEnabled or resizable #10503

Merged
merged 5 commits into from
Oct 8, 2024
Merged

fix(dialog): no longer apply transform styling unless dragEnabled or resizable #10503

merged 5 commits into from
Oct 8, 2024

Conversation

driskull
Copy link
Member

@driskull driskull commented Oct 8, 2024

Related Issue: #10500

Summary

  • no longer apply transform styling unless dragEnabled or resizable
  • add e2e test

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Oct 8, 2024
@driskull driskull marked this pull request as ready for review October 8, 2024 20:23
@driskull driskull requested review from jcfranco and benelan October 8, 2024 20:23
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Oct 8, 2024
@driskull driskull added skip visual snapshots Pull requests that do not need visual regression testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Oct 8, 2024
benelan
benelan approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@driskull driskull merged commit 8234acb into dev Oct 8, 2024
13 checks passed
@driskull driskull deleted the dris0000/dialog-transform-fix branch October 8, 2024 23:09
@github-actions github-actions bot added this to the 2.13.1 patch milestone Oct 8, 2024
benelan pushed a commit that referenced this pull request Oct 11, 2024
@driskull @benelan
fix(dialog): no longer apply transform styling unless dragEnabled or …
e63054c 
…resizable (#10503)

**Related Issue:** #10500

## Summary

- no longer apply transform styling unless dragEnabled or resizable
- add e2e test
@benelan benelan mentioned this pull request Oct 11, 2024
Merged
benelan pushed a commit that referenced this pull request Oct 11, 2024
@driskull @benelan
fix(dialog): no longer apply transform styling unless dragEnabled or …
e93fdbc 
…resizable (#10503)

**Related Issue:** #10500

## Summary

- no longer apply transform styling unless dragEnabled or resizable
- add e2e test
This was referenced Oct 11, 2024
Closed
Merged
benelan added a commit that referenced this pull request Oct 11, 2024
@calcite-admin @benelan
chore: release main (#10530)
6704555 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 2.13.1</summary>

##
[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-10-11)


### Bug Fixes

* **chip:** Fix close icon color inconsistency
([#10493](#10493))
([80b75c2](80b75c2))
* **combobox:** Restores `filterText` when filtered items are empty
([#10498](#10498))
([6667c2a](6667c2a))
* **dialog:** No longer apply transform styling unless dragEnabled or
resizable
([#10503](#10503))
([e93fdbc](e93fdbc))
* **notice:** Ensure closed notice does not affect layout
([#10518](#10518))
([655bbb7](655bbb7))
* **fix(panel):** Revert relative positioning on content
([#10496](#10496))
([239f4da](239f4da))
</details>

<details><summary>@esri/calcite-components-angular: 2.13.1</summary>

##
[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-10-11)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

<details><summary>@esri/calcite-components-react: 2.13.1</summary>

##
[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-10-11)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Ben Elan <[email protected]>
benelan added a commit that referenced this pull request Oct 11, 2024
@calcite-admin @benelan
chore: release main (#10530)
922968b 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 2.13.1</summary>

[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-10-11)

* **chip:** Fix close icon color inconsistency
([#10493](#10493))
([80b75c2](80b75c2))
* **combobox:** Restores `filterText` when filtered items are empty
([#10498](#10498))
([6667c2a](6667c2a))
* **dialog:** No longer apply transform styling unless dragEnabled or
resizable
([#10503](#10503))
([e93fdbc](e93fdbc))
* **notice:** Ensure closed notice does not affect layout
([#10518](#10518))
([655bbb7](655bbb7))
* **fix(panel):** Revert relative positioning on content
([#10496](#10496))
([239f4da](239f4da))
</details>

<details><summary>@esri/calcite-components-angular: 2.13.1</summary>

[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-10-11)

* **@esri/calcite-components-angular:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

<details><summary>@esri/calcite-components-react: 2.13.1</summary>

[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-10-11)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Ben Elan <[email protected]>
@benelan benelan mentioned this pull request Oct 11, 2024
Merged
benelan added a commit that referenced this pull request Oct 11, 2024
@benelan @calcite-admin
chore: release main (#10530)
3546253 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 2.13.1</summary>


[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-10-11)

* **chip:** Fix close icon color inconsistency
([#10493](#10493))

([80b75c2](80b75c2))
* **combobox:** Restores `filterText` when filtered items are empty
([#10498](#10498))

([6667c2a](6667c2a))
* **dialog:** No longer apply transform styling unless dragEnabled or
resizable
([#10503](#10503))

([e93fdbc](e93fdbc))
* **notice:** Ensure closed notice does not affect layout
([#10518](#10518))

([655bbb7](655bbb7))
* **fix(panel):** Revert relative positioning on content
([#10496](#10496))

([239f4da](239f4da))
</details>

<details><summary>@esri/calcite-components-angular: 2.13.1</summary>


[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-10-11)

* **@esri/calcite-components-angular:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

<details><summary>@esri/calcite-components-react: 2.13.1</summary>


[2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-10-11)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0 to 2.13.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See

[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Calcite Admin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan benelan approved these changes

@jcfranco jcfranco Awaiting requested review from jcfranco

Assignees

@driskull driskull

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2.13.1 patch
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @benelan