Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog - avoid setting transform when dialog is not resizable #10500

Closed
2 of 6 tasks
iyouth23 opened this issue Oct 8, 2024 · 3 comments
Closed
2 of 6 tasks

Dialog - avoid setting transform when dialog is not resizable #10500

iyouth23 opened this issue Oct 8, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2.13.1 patch

Comments

@iyouth23
Copy link

iyouth23 commented Oct 8, 2024

Check existing issues

Description

Within calcite-dialog, we set transform here: https://github.com/Esri/calcite-design-system/blob/dev/packages/calcite-components/src/components/dialog/dialog.tsx#L623 even when the dialog is not resizable. This can cause issues with lining up different content.

Acceptance Criteria

Could we set transform only when the dialog is resizable, but otherwise not set it at all?

Relevant Info

Map Viewer needs this for a 2.13 patch for the 2024.R3 release. The transform property is impacting where our Intellisense shows up in the Arcade Editor.

@driskull

Which Component

calcite-dialog

Example Use Case

No response

Priority impact

impact - p1 - need for current milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online
@iyouth23 iyouth23 added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Oct 8, 2024
@github-actions github-actions bot added ArcGIS Online Issues logged by ArcGIS Online team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Oct 8, 2024
@DitwanP DitwanP added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. labels Oct 8, 2024
@DitwanP DitwanP added this to the 2.13.1 patch milestone Oct 8, 2024
@DitwanP DitwanP added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Oct 8, 2024
@DitwanP DitwanP removed the needs triage Planning workflow - pending design/dev review. label Oct 8, 2024
driskull added a commit that referenced this issue Oct 8, 2024
@driskull
fix(dialog): do not apply transform styling when resizing and draggin…
ddfac27 
…g are not enabled. #10500
@driskull driskull mentioned this issue Oct 8, 2024
Merged
driskull added a commit that referenced this issue Oct 8, 2024
@driskull
fix(dialog): no longer apply transform styling unless dragEnabled or …
8234acb 
…resizable (#10503)

**Related Issue:** #10500

## Summary

- no longer apply transform styling unless dragEnabled or resizable
- add e2e test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Installed and assigned for verification.

@geospatialem
Copy link
Member

@iyouth23 Would you be able to verify if Matt's fix mitigates the above with 2.14.0-next.11?

@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. and removed enhancement Issues tied to a new feature or request. labels Oct 10, 2024
@iyouth23
Copy link
Author

@iyouth23 Would you be able to verify if Matt's fix mitigates the above with 2.14.0-next.11?

Looks good @geospatialem, thank you!

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 10, 2024
benelan pushed a commit that referenced this issue Oct 11, 2024
@driskull @benelan
fix(dialog): no longer apply transform styling unless dragEnabled or …
e63054c 
…resizable (#10503)

**Related Issue:** #10500

## Summary

- no longer apply transform styling unless dragEnabled or resizable
- add e2e test
benelan pushed a commit that referenced this issue Oct 11, 2024
@driskull @benelan
fix(dialog): no longer apply transform styling unless dragEnabled or …
e93fdbc 
…resizable (#10503)

**Related Issue:** #10500

## Summary

- no longer apply transform styling unless dragEnabled or resizable
- add e2e test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2.13.1 patch
Development

No branches or pull requests
4 participants
@driskull @geospatialem @iyouth23 @DitwanP