Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stepper-item): update component's active state background color #10487

Merged
merged 1 commit into from
Oct 9, 2024
Merged

feat(stepper-item): update component's active state background color #10487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/calcite-components/src/components/stepper-item/stepper-item.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@
// .stepper-item-header / content
:host .stepper-item-header {
@apply flex cursor-pointer items-start;

&:active {
@apply bg-foreground-3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't done stepper item yet but since you're here, I think this should be background-color: var(--calcite-stepper-item-header-background-color-active, var(--calcite-color-foreground-3);

Then add the jsdocs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alisonailea Kitty and me discussed this, the tokens work is out of scope for this PR. We'll merge this as is and take care of the token in its own issue.

cc @geospatialem

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for summarizing @aPreciado88. @alisonailea Can you make a note in the #7180 epic so we can consider the token when working with the stepper-item component tokens? cc @brittneytewks

}
}

:host .stepper-item-content,
Expand Down
Loading