feat(stepper-item): update component's active state background color #10487
Conversation
aPreciado88
added
the
pr ready for visual snapshots
There was a problem hiding this comment.
Code changes, LGTM! @SkyeSeitz can you help review the visual diff? 👀
Changes look great. Chromatic approved ✅ |
| @@ -73,6 +73,10 @@ | |||
| // .stepper-item-header / content | |||
| :host .stepper-item-header { | |||
| @apply flex cursor-pointer items-start; | |||
|
|
|||
| &:active { | |||
| @apply bg-foreground-3; | |||
There was a problem hiding this comment.
We haven't done stepper item yet but since you're here, I think this should be background-color: var(--calcite-stepper-item-header-background-color-active, var(--calcite-color-foreground-3);
Then add the jsdocs
There was a problem hiding this comment.
@alisonailea Kitty and me discussed this, the tokens work is out of scope for this PR. We'll merge this as is and take care of the token in its own issue.
There was a problem hiding this comment.
Thanks for summarizing @aPreciado88. @alisonailea Can you make a note in the #7180 epic so we can consider the token when working with the stepper-item component tokens? cc @brittneytewks
aPreciado88
dismissed
alisonailea’s stale review
This change is out of scope for this PR.
aPreciado88
deleted the
aPreciado88/10000-enhance-component-interactive-states
branch
Related Issue: #10000
Summary
Add
bg-foreground-3to the component'sactivestate.