Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab selection underline is not aligned when icon is added to tab #6821

Closed
mpayson opened this issue Apr 21, 2023 · 4 comments
Closed

Tab selection underline is not aligned when icon is added to tab #6821

mpayson opened this issue Apr 21, 2023 · 4 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2023 September Pr...

Comments

@mpayson
Copy link

mpayson commented Apr 21, 2023

Actual Behavior

When an icon is added to another tab, the selection underline for the current tab title is not aligned to the title content

Screenshot 2023-04-21 at 7 21 03 AM

Expected Behavior

The selection underline adjusts to align with the title content

Reproduction Sample

https://codepen.io/mpayson/pen/YzJpbpe

Reproduction Steps

  1. Open sample
  2. Click "Add indicator"
  3. See underline is not aligned

Reproduction Version

1.2.0

Relevant Info

Similar to #4896, but this issue occurs when the indicator is added to a tab other than the selected tab

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Impact

No response

Esri team

ArcGIS Online
@mpayson mpayson added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Apr 21, 2023
@github-actions github-actions bot added ArcGIS Online Issues logged by ArcGIS Online team members. p3 - want for upcoming milestone labels Apr 21, 2023
@macandcheese
Copy link
Contributor

Likely need to observe the Tab Title for a change in width and trigger a re-calculation of the needed indicator width.

@macandcheese
Copy link
Contributor

cc @ashetland @SkyeSeitz regarding that conversation about this indicator element / animation.

@geospatialem geospatialem added estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library labels Jul 19, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Jul 19, 2023
@driskull driskull self-assigned this Sep 19, 2023
@driskull driskull added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Sep 19, 2023
driskull added a commit that referenced this issue Sep 19, 2023
@driskull
fix(tab-nav): update indicator position when tab icon changes. #6821
2b16600
@driskull driskull mentioned this issue Sep 19, 2023
Merged
driskull added a commit that referenced this issue Sep 19, 2023
@driskull
fix(tab-nav): update indicator position when tab icon changes (#7768)
cb877b3 
**Related Issue:** #6821

## Summary

- Updates offset position when tab icon is added
- Add screenshot test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Sep 19, 2023
@github-actions github-actions bot assigned geospatialem and unassigned driskull Sep 19, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Sep 20, 2023
@geospatialem
Copy link
Member

Verified in 1.9.0-next.5

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2023 September Priorities - Main release
Development

No branches or pull requests
4 participants
@driskull @macandcheese @geospatialem @mpayson