Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Active tab underline doesn't fill the width if an icon is dynamically added #4896

Closed
mpayson opened this issue Jul 11, 2022 · 2 comments
Closed

Active tab underline doesn't fill the width if an icon is dynamically added #4896

mpayson opened this issue Jul 11, 2022 · 2 comments
Assignees
@geospatialem @benelan
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.
Milestone
Sprint 2022/09/05...

Comments

@mpayson
Copy link

mpayson commented Jul 11, 2022 •
edited
Loading

Actual Behavior

If an icon is dynamically added to an active tab title, the underline for the title does not fill the width
Screen Shot 2022-07-11 at 2 53 44 PM

Expected Behavior

The underline width matches the width of the title

Reproduction Sample

https://codepen.io/mpayson/pen/jOzrXaE

Reproduction Steps

  1. Open the code pen
  2. Click the button
  3. Notice an indicator is added and the underline is short

Reproduction Version

beta.83

Relevant Info

No response

Regression?

No response
@mpayson mpayson added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Jul 11, 2022
@geospatialem geospatialem added this to the Sprint 8/8 - 08/19 milestone Jul 22, 2022
@benelan benelan modified the milestones: Sprint 8/8 - 08/19, Sprint 2022/08/08 - 2022/08/19 Jul 22, 2022
@anveshmekala anveshmekala self-assigned this Aug 31, 2022
@anveshmekala anveshmekala mentioned this issue Aug 31, 2022
Merged
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Sep 13, 2022
@github-actions github-actions bot assigned benelan and geospatialem and unassigned anveshmekala Sep 13, 2022
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 4, 2022
@geospatialem
Copy link
Member

Verified in beta.95.

verified active tab style for tab with indicator

@mpayson mpayson mentioned this issue Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@benelan benelan

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Milestone
Sprint 2022/09/05 - 2022/09/16
Development

No branches or pull requests
4 participants
@geospatialem @mpayson @benelan @anveshmekala