-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calcite-modal
's scale overrides calcite-input
's scale
#6494
Comments
This is legacy behavior that snuck into 1.0.0, and can have unintended consequences if component ancestors have Related issues: |
… prevent components from unintentionally picking up a different scale/status value from an ancestor (#6506) **Related Issue:** #6494 ## Summary This PR updates remaining non-children components to no longer look up their ancestry to set props. --------- Co-authored-by: Ali Stump <[email protected]>
Installed and assigned for verification. |
@omarkawach Wasn't able to repro the original issue in the Codepen to verify if the fix is working now. Could you verify if the Arcade editor is working as-expected with |
Verified the fix in the editor 🙂 I will reopen this issue if the problem comes up again. |
Awesome, thank you @omarkawach! Marking this as verified and closing it out for the upcoming April release. |
Actual Behavior
When calcite-input gets loaded by the lazy loader (the first time), it disregards its own scale and searches the ancestry for a scale.
In the case of a modal set to scale="l", the calcite-input will find the modal and use it for its scale even though the calcite-input was set to scale "m".
Our subsequent calcite-input instances are working correctly in the Arcade editor
Expected Behavior
The scale of calcite-input should not be overwritten by another component when a scale is already set
Reproduction Sample
https://github.com/Esri/calcite-components/blob/cad286dd84163d61aae15c55dac3c01808aea221/src/components/input/input.tsx#L452
Reproduction Steps
Sharing the problematic line of code. Talk to @jcfranco
Difficult to reproduce in a codepen https://codepen.io/omarkawach/pen/VwGYMmo
Reproduction Version
1.0.7
Relevant Info
No response
Regression?
No response
Impact
We had to do a workaround for now
This way calcite input finds an ancestor with a scale other than the modal's scale.
Esri team
ArcGIS Online
The text was updated successfully, but these errors were encountered: