-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Input Message / Input] Remove usage of getElementProp
to set status
#3755
Comments
To clarify (I think), this property should be kept on The verbiage on |
getElementProp
to set status
Is it also recommended to remove the verbiage or change the code demo by adding additional status prop in the components for calcite-input and calcite-input-mesage? |
Does |
No, we should deprecate it or remove it. |
Installed and assigned for verification. |
verified on beta.76 |
Description
calcite-input-message
andcalcite-input
should not usegetElementProp
to setstatus
.Proposed Advantages
This is not a great pattern for inheriting properties - as of now it only detects and sets on load. Users should manage
status
on each component individually.Relevant Info
The verbiage on
calcite-label
here: (https://github.com/Esri/calcite-components/tree/master/src/components/calcite-label#basic) should also be removed.Which Component
calcite-input-message
calcite-input
calcite-label
cc @driskull
The text was updated successfully, but these errors were encountered: