Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block: too many loading indicators #6485

Closed
ashetland opened this issue Feb 15, 2023 · 6 comments
Closed

Block: too many loading indicators #6485

ashetland opened this issue Feb 15, 2023 · 6 comments
Assignees
@geospatialem @SkyeSeitz @ashetland @brittneytewks
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation.
Milestone
2023 July Priorities

Comments

@ashetland
Copy link
Contributor

Actual Behavior

Block's header has two loading indicators.
image

Expected Behavior

One loading indicator, either on the left or the right. Prefer the inline calcite-loader for consistency.

Reproduction Sample

https://codepen.io/ashetland/pen/GRBbOXK

Reproduction Steps

  1. Open codepen.
  2. Collapse and expand Blocks to see loading behavior.

Reproduction Version

1.0.5

Relevant Info

cc @alan

Regression?

No response

Impact

No response

Esri team

Calcite (design)
@ashetland ashetland added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Feb 15, 2023
@github-actions github-actions bot added the Calcite (design) Issues logged by Calcite designers. label Feb 15, 2023
@macandcheese
Copy link
Contributor

Cc @asangma / @mitc7862 for insight / historical context / need for MV

@ashetland
Copy link
Contributor Author

After a quick chat with @asangma, propose we use the calcite-loader for consistency, but use the icon slot like before. This would reduce adding more items to the right side.

image

@geospatialem geospatialem added ready for dev Issues ready for development implementation. enhancement Issues tied to a new feature or request. p - low Issue is non core or affecting less that 10% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Apr 18, 2023
@geospatialem geospatialem added this to the 2023 July Priorities milestone May 1, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label May 1, 2023
@ashetland ashetland added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Jun 5, 2023
@Elijbet Elijbet self-assigned this Jun 28, 2023
@Elijbet Elijbet added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Jun 28, 2023
@Elijbet Elijbet mentioned this issue Jun 28, 2023
Merged
@Elijbet Elijbet added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 28, 2023
benelan pushed a commit that referenced this issue Jun 29, 2023
@Elijbet
fix(block): removes extra loading indicator (#7239)
a334a75 
**Related Issue:** #6485

## Summary

`calcite-block header` had two loading indicators. This removes the
extra `calcite-loader` from the right end, and places it as an option in
`icon-slot`,`statusIcons: valid or invalid` as well as `controls` now
appear regardless of `loading` state.
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. 4 - verified Issues that have been released and confirmed resolved. labels Jul 3, 2023
@Esri Esri deleted a comment from github-actions bot Jul 3, 2023
@geospatialem
Copy link
Member

Moving back to development per #7239 (comment) and #7239 (comment)

@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 9, 2023
@Elijbet Elijbet mentioned this issue Jul 10, 2023
Merged
Elijbet added a commit that referenced this issue Jul 12, 2023
@Elijbet
fix(block): loader now appears for all loading cases (#7303)
5af3600 
**Related Issue:** #6485

## Summary
Continues on #7239 to cover additional cases where loader needs to
appear when there is no `status icon` or if there is a `slottedIcon` so
that the loading icon shows both when a collapsible block is `open` and
`closed`. Any slotted icons get overridden when loading.
@Elijbet Elijbet added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 12, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@ashetland ashetland mentioned this issue Jul 12, 2023
Closed
3 tasks
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 24, 2023
@geospatialem
Copy link
Member

Verified in 1.5.0-next.25 with https://codepen.io/geospatialem/pen/poQPgNG.

image

@SkyeSeitz SkyeSeitz mentioned this issue Aug 8, 2023
Open
3 tasks
@SkyeSeitz SkyeSeitz removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Oct 27, 2023
@brittneytewks brittneytewks added the design Issues that need design consultation prior to development. label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@SkyeSeitz SkyeSeitz

@ashetland ashetland

@brittneytewks brittneytewks

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2023 July Priorities
Development

No branches or pull requests
7 participants
@alisonailea @macandcheese @geospatialem @Elijbet @SkyeSeitz @ashetland @brittneytewks